After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732756 - faceblur: Render black when input is GLMemory
faceblur: Render black when input is GLMemory
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.3.90
Other Linux
: Normal normal
: 1.3.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-05 01:11 UTC by Nicolas Dufresne (ndufresne)
Modified: 2014-07-05 01:21 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Nicolas Dufresne (ndufresne) 2014-07-05 01:11:59 UTC
Faceblur has some buffer mapping error that lead to black frame when GLMemory is sent as input. The ideal solution was to port to the filter base class.
Comment 1 Nicolas Dufresne (ndufresne) 2014-07-05 01:21:26 UTC
commit 34e23c2e2168a8b4fd84eba2fd2d8900aaf368da
Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Date:   Fri Jul 4 20:33:41 2014 -0400

    faceblur: Port to OpencvVideoFilter base class
    
    This fixes issue whit black frames when special memory, like GlMemory is
    in used.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=732756

commit 42a83d2c64387150528fae93a781e522f177dc7f
Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Date:   Fri Jul 4 20:31:50 2014 -0400

    cvvideofilter: Don't try to make buffer writable
    
    First this is handle by base transform, hence this is a no-op, and if it wasn't it
    would lead to a buffer copy being leaked, and then an unreffed buffer being
    pushed downstream.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=732756

commit 2acdb2ecf2d05b249e5aa63848e9ee0be51a79c4
Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Date:   Fri Jul 4 20:30:20 2014 -0400

    cvvideofilter: Check buffer_map return value
    
    Check the resturn value and cleanly fail if we could not mapped the buffers.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=732756