After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731581 - curlsshsink: use the locally defined types instead of libcurl's
curlsshsink: use the locally defined types instead of libcurl's
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal trivial
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-12 15:29 UTC by Sorin L.
Modified: 2014-10-26 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use our own GstCurlSshAuthType type (2.59 KB, patch)
2014-06-12 15:29 UTC, Sorin L. 		needs-work Details | Review
added comment on enum definition (3.14 KB, patch)
2014-10-14 14:57 UTC, Sorin L. 		committed Details | Review

Description Sorin L. 2014-06-12 15:29:24 UTC 
Created attachment 278351 [details] [review]
use our own GstCurlSshAuthType type

Since we have our own "GstCurlSshAuthType" it feels right to use that one.
Comment 1 Olivier Crête 2014-06-23 20:37:58 UTC 
They must match exactly, so I'm not sure it matters much.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2014-09-24 21:00:09 UTC 
Oliver, the way they are defined, they do match:
typedef enum
{
  GST_CURLSSH_AUTH_NONE = CURLSSH_AUTH_NONE,
  GST_CURLSSH_AUTH_PUBLICKEY = CURLSSH_AUTH_PUBLICKEY,
  GST_CURLSSH_AUTH_PASSWORD = CURLSSH_AUTH_PASSWORD
} GstCurlSshAuthType;
Comment 3 Sebastian Dröge (slomo) 2014-09-25 08:05:22 UTC 
Comment on attachment 278351 [details] [review]
use our own GstCurlSshAuthType type

Please add a comment to the enum, saying that these must always be kept in sync with the definitions from curl.
Comment 4 Sorin L. 2014-10-14 14:57:47 UTC 
Created attachment 288528 [details] [review]
added comment on enum definition

Added comment as hinted above...
Comment 5 Tim-Philipp Müller 2014-10-26 21:09:57 UTC 
Pushed, thanks:

commit 09f0b037629a3e59d9e63c7083f59df9d9fd9db5
Author: L. Sorin <sorin@axis.com>
Date:   Thu Jun 12 16:59:46 2014 +0200

    curlsshsink: use the locally defined types
    
    Just a matter of coding style, makes the code a bit tidier...
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731581