After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730901 - example: ts-parser: add linkage descriptor
example: ts-parser: add linkage descriptor
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-28 18:47 UTC by Stefan Ringel
Modified: 2014-05-29 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
bugfix missmage linkage parsing (1.03 KB, patch)
2014-05-28 18:47 UTC, Stefan Ringel
committed Details | Review
add linkage descriptor (5.85 KB, patch)
2014-05-28 18:47 UTC, Stefan Ringel
needs-work Details | Review
add linkage descriptor (6.07 KB, patch)
2014-05-29 08:52 UTC, Stefan Ringel
committed Details | Review

Description Stefan Ringel 2014-05-28 18:47:09 UTC
Created attachment 277407 [details] [review]
bugfix missmage linkage parsing

example: ts-parser: add linkage descriptor
Comment 1 Stefan Ringel 2014-05-28 18:47:31 UTC
Created attachment 277408 [details] [review]
add linkage descriptor
Comment 2 Edward Hervey 2014-05-29 05:56:18 UTC
Review of attachment 277408 [details] [review]:

::: tests/examples/mpegts/ts-parser.c
@@ +79,3 @@
 
+static void
+dump_memory_bytes (guint8 * data, guint len, guint spacing)

Can you also refactor dump_memory_content() to call this (with desc->data + 2, desc->length - 2) ?

@@ +451,3 @@
+    }
+    if (res.private_data_length > 0) {
+      dump_memory_bytes (res.private_data_bytes, res.private_data_length,

Just realized that these fields (and other fields of the linkagedescriptor) are being leaked because they don't have a free/reset function.

I'm going to open a separate bug regarding this (common) issue
Comment 3 Stefan Ringel 2014-05-29 06:08:53 UTC
(In reply to comment #2)
> Review of attachment 277408 [details] [review]:
> 
> ::: tests/examples/mpegts/ts-parser.c
> @@ +79,3 @@
> 
> +static void
> +dump_memory_bytes (guint8 * data, guint len, guint spacing)
> 
> Can you also refactor dump_memory_content() to call this (with desc->data + 2,
> desc->length - 2) ?

Don't work. we have a variable position, what we don't know.
Comment 4 Edward Hervey 2014-05-29 06:23:02 UTC
(In reply to comment #3)
> Don't work. we have a variable position, what we don't know.

I don't understand what you mean.

BTW, the bug regarding allocation/g-i : https://bugzilla.gnome.org/show_bug.cgi?id=730914
Comment 5 Stefan Ringel 2014-05-29 06:53:46 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Don't work. we have a variable position, what we don't know.
> 
> I don't understand what you mean.
> 
> BTW, the bug regarding allocation/g-i :
> https://bugzilla.gnome.org/show_bug.cgi?id=730914

my fault, I have overseen the second part of your comment.
Comment 6 Stefan Ringel 2014-05-29 08:52:18 UTC
Created attachment 277439 [details] [review]
add linkage descriptor
Comment 7 Edward Hervey 2014-05-29 09:56:48 UTC
commit 74681cf00a3ab17d54963e7dbb8b2abaf259fd8e
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Thu May 29 11:55:51 2014 +0200

    examples: factor dumping code
    
    We can just re-use the new function instead of having two duplicates

commit 1db9d6c9dffeb47b4371e836a7cf559e67c17dd8
Author: Stefan Ringel <linuxtv@stefanringel.de>
Date:   Thu May 29 10:50:58 2014 +0200

    example: ts-parser: add linkage descriptor
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730901

commit f6fdd83b7ed47ae92d4857f0ca07edd136cce6dd
Author: Stefan Ringel <linuxtv@stefanringel.de>
Date:   Wed May 28 20:42:05 2014 +0200

    mpegts: bugfix mobile hand over linkage parse missmatch
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730901