After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730574 - hlsdemux: Saving IV from media sequence number is done out of file->iv structure
hlsdemux: Saving IV from media sequence number is done out of file->iv structure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.3.2
Other Linux
: Normal minor
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-22 11:05 UTC by Damian Ziobro
Modified: 2014-05-22 12:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Damian Ziobro 2014-05-22 11:05:04 UTC 
[10:59] <damianZiobro> hi I am analyzing code of hlsdemux and I found bug there
[10:59] <damianZiobro> in gst-plugins-bad version 1.3.2
[11:00] <damianZiobro> file ext/hls/m3u8.c line 352
[11:00] <damianZiobro> there is such code there:
[11:00] <damianZiobro>            guint8 *iv = file->iv + 12;             GST_WRITE_UINT32_BE (iv + 12, file->sequence);
[11:00] <damianZiobro> so we are basically moving 12 bytes two times
[11:00] <damianZiobro> file->iv structure has 16 bytes
[11:01] <damianZiobro> so wile we are moving 12 bytes 2 times we are out of structure which we are trying to write to
[11:01] <damianZiobro> I think it is bug
[11:01] <damianZiobro> moving 12 bytes should be done only once

SOLUTION: 
 Patch with the solution of this bug I pasted here: http://pastebin.com/6APZeHar
Comment 1 Damian Ziobro 2014-05-22 11:06:32 UTC 
SOLUTION:
 Patch with the solution of this bug I pasted here:
http://pastebin.com/6APZeHar
Comment 2 Sebastian Dröge (slomo) 2014-05-22 11:28:31 UTC 
You can also just attach patches to bugzilla btw :)

commit 5b547a553d200d0011f57617999b334eb6599533
Author: Damian Ziobro <ziobro.damian@gmail.com>
Date:   Thu May 22 11:54:40 2014 +0100

    hlsdemux: Fix storing of the IV based on the media sequence number
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730574