GNOME Bugzilla – Bug 720205
playback: add video/x-raw(ANY) to default raw caps
Last modified: 2013-12-30 10:26:39 UTC
This patch allows elements using video caps features to be used by playbin.
Created attachment 263933 [details] [review] [PATCH 1/1] playback: add video/x-raw(ANY) to default raw caps
Comment on attachment 263933 [details] [review] [PATCH 1/1] playback: add video/x-raw(ANY) to default raw caps Not complete, see gstplaybin2.c:static GstStaticCaps raw_audio_caps = GST_STATIC_CAPS ("audio/x-raw") gstplaysink.c: if (g_str_equal (name, "video/x-raw") || g_str_equal (name, "audio/x-raw")) gstsubtitleoverlay.c: if (g_str_equal (name, "video/x-raw"))
Created attachment 264276 [details] [review] playback: add video/x-raw(ANY) to default raw caps
(In reply to comment #2) > (From update of attachment 263933 [details] [review]) > Not complete, see > > gstplaybin2.c:static GstStaticCaps raw_audio_caps = GST_STATIC_CAPS > ("audio/x-raw") raw_video_caps updated in patch. > > gstplaysink.c: if (g_str_equal (name, "video/x-raw") || g_str_equal (name, > "audio/x-raw")) > > gstsubtitleoverlay.c: if (g_str_equal (name, "video/x-raw")) gst_structure_get_name () returns video/x-raw even if caps are video/x-raw(ANY) so it does need any modifications in my point of view. By the way, i'm wondering how playbin should behave (in the long term) when hardware decoder are plugged, ie: try to plug videoconvert / deinterlace/ videobalance elements compatible with the caps features ?
Comment on attachment 264276 [details] [review] playback: add video/x-raw(ANY) to default raw caps I think we should do the same for audio for consistency
Created attachment 264926 [details] [review] playback: add ANY caps features to default audio/video raw caps
commit 98e0dec7151bb8798c783f43bc2b963ce1089c51 Author: Matthieu Bouron <matthieu.bouron@collabora.com> Date: Tue Dec 10 15:19:14 2013 +0000 playback: add ANY caps features to default audio/video raw caps Allows elements using audio/video caps features to be used by playbin.