After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720205 - playback: add video/x-raw(ANY) to default raw caps
playback: add video/x-raw(ANY) to default raw caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-10 17:24 UTC by Matthieu Bouron
Modified: 2013-12-30 10:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH 1/1] playback: add video/x-raw(ANY) to default raw caps (727 bytes, patch)
2013-12-10 17:25 UTC, Matthieu Bouron
needs-work Details | Review
playback: add video/x-raw(ANY) to default raw caps (1.29 KB, patch)
2013-12-16 12:22 UTC, Matthieu Bouron
needs-work Details | Review
playback: add ANY caps features to default audio/video raw caps (1.46 KB, patch)
2013-12-27 10:17 UTC, Matthieu Bouron
committed Details | Review

Description Matthieu Bouron 2013-12-10 17:24:22 UTC
This patch allows elements using video caps features to be used by playbin.
Comment 1 Matthieu Bouron 2013-12-10 17:25:25 UTC
Created attachment 263933 [details] [review]
[PATCH 1/1] playback: add video/x-raw(ANY) to default raw caps
Comment 2 Sebastian Dröge (slomo) 2013-12-14 17:27:32 UTC
Comment on attachment 263933 [details] [review]
[PATCH 1/1] playback: add video/x-raw(ANY) to default raw caps

Not complete, see

gstplaybin2.c:static GstStaticCaps raw_audio_caps = GST_STATIC_CAPS ("audio/x-raw")

gstplaysink.c:  if (g_str_equal (name, "video/x-raw") || g_str_equal (name, "audio/x-raw"))

gstsubtitleoverlay.c:  if (g_str_equal (name, "video/x-raw"))
Comment 3 Matthieu Bouron 2013-12-16 12:22:36 UTC
Created attachment 264276 [details] [review]
playback: add video/x-raw(ANY) to default raw caps
Comment 4 Matthieu Bouron 2013-12-16 12:27:33 UTC
(In reply to comment #2)
> (From update of attachment 263933 [details] [review])
> Not complete, see
> 
> gstplaybin2.c:static GstStaticCaps raw_audio_caps = GST_STATIC_CAPS
> ("audio/x-raw")

raw_video_caps updated in patch.

> 
> gstplaysink.c:  if (g_str_equal (name, "video/x-raw") || g_str_equal (name,
> "audio/x-raw"))
> 
> gstsubtitleoverlay.c:  if (g_str_equal (name, "video/x-raw"))

gst_structure_get_name () returns video/x-raw even if caps are video/x-raw(ANY) so it does need any modifications in my point of view.

By the way, i'm wondering how playbin should behave (in the long term) when hardware decoder are plugged, ie: try to plug videoconvert / deinterlace/ videobalance elements compatible with the caps features ?
Comment 5 Sebastian Dröge (slomo) 2013-12-16 14:54:37 UTC
Comment on attachment 264276 [details] [review]
playback: add video/x-raw(ANY) to default raw caps

I think we should do the same for audio for consistency
Comment 6 Matthieu Bouron 2013-12-27 10:17:16 UTC
Created attachment 264926 [details] [review]
playback: add ANY caps features to default audio/video raw caps
Comment 7 Sebastian Dröge (slomo) 2013-12-30 10:26:07 UTC
commit 98e0dec7151bb8798c783f43bc2b963ce1089c51
Author: Matthieu Bouron <matthieu.bouron@collabora.com>
Date:   Tue Dec 10 15:19:14 2013 +0000

    playback: add ANY caps features to default audio/video raw caps
    
    Allows elements using audio/video caps features to be used by playbin.