After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710296 - Focus is getting removed from the target window
Focus is getting removed from the target window
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-16 16:12 UTC by Parag AN
Modified: 2013-12-16 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
display: Don't focus the no-focus-window when sending WM_TAKE_FOCUS to a globally active window (2.34 KB, patch)
2013-10-17 03:03 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Parag AN 2013-10-16 16:12:46 UTC
On Fedora 20 updated system, I found any onscreen keyboard like iok, eekboard, cellwriter and florence stopped working. Looks like focus is getting removed from the target window.

Initial bug and some observation on it are at https://bugzilla.redhat.com/show_bug.cgi?id=1019073

Installed packages:
mutter-wayland-3.10.0.1-3.fc20.x86_64
mutter-3.10.0.1-1.fc20.x86_64


These OSK should be working normal again in Fedora 20.
Comment 1 Parag AN 2013-10-16 16:46:04 UTC
found this commit https://git.gnome.org/browse/mutter/commit/?id=7fdfbad6d495ede1632588e528801443846e5f6d which could have caused this bug.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-10-17 03:03:26 UTC
Created attachment 257476 [details] [review]
display: Don't focus the no-focus-window when sending WM_TAKE_FOCUS to a globally active window

Clients like on-screen keyboards try not to tak efocus when the user clicks
on their window by setting the Input hint to false. However, due to GTK+ and
GDK bugs, the public API for setting the Input hint to false don't remove
WM_TAKE_FOCUS from WM_PROTOCOLS, unintentionally putting them into Globally
Active mode.

These clients also expect that since they don't want to take focus, they want
the focus to remain on the existing window. In this case, for clients like
on-screen keyboards, it's so they can send synthesized keyboard events to the
focused window.
Comment 3 Parag AN 2013-10-17 04:19:26 UTC
I added this patch in fedora 20 mutter.spec and installed new package. This proposed patch is fixing the reported issue. Thanks.
Comment 4 Matthias Clasen 2013-10-17 11:59:09 UTC
If there's a gtk bug here, I'd appreciate a bug and patch
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-10-17 13:14:13 UTC
Filed as https://bugzilla.gnome.org/show_bug.cgi?id=710389
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-10-29 20:26:26 UTC
Attachment 257476 [details] pushed as b82784e - display: Don't focus the no-focus-window when sending WM_TAKE_FOCUS to a globally active window
Comment 7 Parag AN 2013-11-16 06:50:48 UTC
When will this fix be available in Fedora 20 or 3.10.x series?
Comment 8 Parag AN 2013-12-10 12:28:14 UTC
When will this fix be available in Fedora 20 or 3.10.x series? This will now solve the OSK issue present in Fedora 20.
Comment 9 Owen Taylor 2013-12-16 16:58:36 UTC
(In reply to comment #8)
> When will this fix be available in Fedora 20 or 3.10.x series? This will now
> solve the OSK issue present in Fedora 20.

This patch was added to the Fedora 20 RPM and also added to the 3.10 branch. [Causing bug 711618]