After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708104 - Album view: show songs without an associated album (as belonging to Unknown Album)
Album view: show songs without an associated album (as belonging to Unknown A...
Status: RESOLVED OBSOLETE
Product: gnome-music
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal enhancement
: 3.18
Assigned To: gnome-music-maint
gnome-music-maint
: 708064 744705 784508 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-09-15 05:56 UTC by Arnel Borja
Modified: 2018-01-10 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add 'Unknown' container for songs unassociated to any album (4.22 KB, patch)
2016-03-30 19:16 UTC, Saiful B. Khan
none Details | Review
Second Patch (4.22 KB, patch)
2016-04-15 13:01 UTC, Saiful B. Khan
none Details | Review
3rd patch (4.32 KB, patch)
2016-04-15 19:22 UTC, Saiful B. Khan
none Details | Review

Description Arnel Borja 2013-09-15 05:56:51 UTC
Currently we just ignore songs if they have an empty album metadata.
Comment 1 Arnel Borja 2013-09-15 05:57:39 UTC
Forgot to say this should be in Albums view.
Comment 2 Sai Suman Prayaga 2014-02-19 18:04:00 UTC
We are not doing this for artists view either. This needs to be done for songs with no artists in artists view.
Comment 3 Arnel Borja 2014-03-18 17:33:17 UTC
I think we need new queries that fetches songs which don't have album (for Albums view) or don't have artist (for Artists view). I've checked last night and it seems it could be something like the query for the Songs view but with NOT EXISTS filter for artist or album key.

After that, the results of the query could be added to a container or we could create objects for artists and albums, or add them manually to each views just like what we do in All Artists in Artists view.

I'm still looking for a better solution though - something that would just modify the existing queries for Artists and Albums view. The problem is, tracker doesn't create an "Unknown Artist" or something like that in its database, so I'm probably looking for something non-existent XD.

Or maybe we could combine it and the "Unknown XXX" queries - I don't have much experience playing with SPARQL and still studying it, I don't know if that's possible.
Comment 4 Allan Day 2014-04-22 19:39:19 UTC
Sounds good to me.
Comment 5 Allan Day 2014-04-22 19:40:36 UTC
Bug 708064 tracks the corresponding issue for the artist view.
Comment 6 Vadim Rutkovsky 2015-02-18 14:28:53 UTC
*** Bug 744705 has been marked as a duplicate of this bug. ***
Comment 7 Allan Day 2016-01-05 14:41:17 UTC
Coming back to this bug, it took me a while to understand what it was for. Updating the title to make it clearer.
Comment 8 Allan Day 2016-01-06 13:11:39 UTC
Bulk removing the 3.18 target.
Comment 9 Allan Day 2016-01-06 13:16:37 UTC
Removing the available whiteboard - we're not really using it any more.
Comment 10 Saiful B. Khan 2016-03-30 19:16:23 UTC
Created attachment 325041 [details] [review]
Add 'Unknown' container for songs unassociated to any album

As suggested by Arnel, a container for songs filtered with 'NOT EXISTS { album }' was added. Any other suggestions are welcome.
Comment 11 Felipe Borges 2016-04-11 11:24:38 UTC
Review of attachment 325041 [details] [review]:

Thanks. It works like a charm.

::: gnomemusic/view.py
@@ +222,3 @@
+                               self.cache.get_default_icon(self._iconWidth, self._iconHeight),
+                               unknown_media, 0, False])
+            tracker_cursor = grilo.sparqltracker.query(check_query, None)

Could you please move this query to the Query class (at query.py)?
Comment 12 Saiful B. Khan 2016-04-15 13:01:08 UTC
Created attachment 326092 [details] [review]
Second Patch

The query for checking song count was moved to its correct place.
Comment 13 Saiful B. Khan 2016-04-15 19:22:56 UTC
Created attachment 326135 [details] [review]
3rd patch

Ignore the above patch. I re-uploaded the same patch by mistake :P
This one should do it.
Comment 14 Marinus Schraal 2016-05-14 12:16:50 UTC
I'm not a big fan of this as it currently is.

To me an 'Unknown' album in a list of albums doesn't really scream that it is supposed to contain all (badly tagged?) songs without an album. Also this album would probably then contain a load of totally unrelated songs. Same goes for the artist view.

I think this is more something for an auto-generated playlist. From there users can then select and combine songs to create sensible playlists out of these songs or choose to correct their tags (with the landing of tagging support hopefully after gsoc).
Comment 15 Marinus Schraal 2016-05-14 12:19:54 UTC
*** Bug 708064 has been marked as a duplicate of this bug. ***
Comment 16 Marinus Schraal 2017-07-17 10:53:16 UTC
*** Bug 784508 has been marked as a duplicate of this bug. ***
Comment 17 GNOME Infrastructure Team 2018-01-10 14:34:28 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-music/issues/7.