GNOME Bugzilla – Bug 708104
Album view: show songs without an associated album (as belonging to Unknown Album)
Last modified: 2018-01-10 14:34:28 UTC
Currently we just ignore songs if they have an empty album metadata.
Forgot to say this should be in Albums view.
We are not doing this for artists view either. This needs to be done for songs with no artists in artists view.
I think we need new queries that fetches songs which don't have album (for Albums view) or don't have artist (for Artists view). I've checked last night and it seems it could be something like the query for the Songs view but with NOT EXISTS filter for artist or album key. After that, the results of the query could be added to a container or we could create objects for artists and albums, or add them manually to each views just like what we do in All Artists in Artists view. I'm still looking for a better solution though - something that would just modify the existing queries for Artists and Albums view. The problem is, tracker doesn't create an "Unknown Artist" or something like that in its database, so I'm probably looking for something non-existent XD. Or maybe we could combine it and the "Unknown XXX" queries - I don't have much experience playing with SPARQL and still studying it, I don't know if that's possible.
Sounds good to me.
Bug 708064 tracks the corresponding issue for the artist view.
*** Bug 744705 has been marked as a duplicate of this bug. ***
Coming back to this bug, it took me a while to understand what it was for. Updating the title to make it clearer.
Bulk removing the 3.18 target.
Removing the available whiteboard - we're not really using it any more.
Created attachment 325041 [details] [review] Add 'Unknown' container for songs unassociated to any album As suggested by Arnel, a container for songs filtered with 'NOT EXISTS { album }' was added. Any other suggestions are welcome.
Review of attachment 325041 [details] [review]: Thanks. It works like a charm. ::: gnomemusic/view.py @@ +222,3 @@ + self.cache.get_default_icon(self._iconWidth, self._iconHeight), + unknown_media, 0, False]) + tracker_cursor = grilo.sparqltracker.query(check_query, None) Could you please move this query to the Query class (at query.py)?
Created attachment 326092 [details] [review] Second Patch The query for checking song count was moved to its correct place.
Created attachment 326135 [details] [review] 3rd patch Ignore the above patch. I re-uploaded the same patch by mistake :P This one should do it.
I'm not a big fan of this as it currently is. To me an 'Unknown' album in a list of albums doesn't really scream that it is supposed to contain all (badly tagged?) songs without an album. Also this album would probably then contain a load of totally unrelated songs. Same goes for the artist view. I think this is more something for an auto-generated playlist. From there users can then select and combine songs to create sensible playlists out of these songs or choose to correct their tags (with the landing of tagging support hopefully after gsoc).
*** Bug 708064 has been marked as a duplicate of this bug. ***
*** Bug 784508 has been marked as a duplicate of this bug. ***
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-music/issues/7.