After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707073 - Message tray menu is missing the notifications switch
Message tray menu is missing the notifications switch
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 709045 709146 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-08-29 18:05 UTC by Allan Day
Modified: 2014-04-14 17:07 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10


Attachments
messageTray: Add 'Notifications' switch to tray menu (3.91 KB, patch)
2013-09-30 15:03 UTC, Florian Müllner
committed Details | Review

Description Allan Day 2013-08-29 18:05:34 UTC
This is a regression from previous releases - we used to have a switch which would disable non-urgent notifications. This was included in the mockups for the message tray menu.
Comment 1 Allan Day 2013-08-29 18:38:57 UTC
When notifications are disabled:

 * Chat status should be set to Busy
 * Notification banners should no longer be displayed
 * Urgent banners should still be displayed
 * Notifications for adding/removing favourites should still be displayed 
 * If you set your chat status to something other than Busy/Invisible/Offline, notifications should be enabled again
Comment 2 Florian Müllner 2013-08-29 20:05:52 UTC
(In reply to comment #1)
> When notifications are disabled:
>  * If you set your chat status to something other than Busy/Invisible/Offline,
> notifications should be enabled again

Does this still make sense without the integrated status switcher?
Comment 3 Allan Day 2013-08-30 10:23:30 UTC
(In reply to comment #2) 
> Does this still make sense without the integrated status switcher?

I think it does - the message tray menu provides feedback about your chat status, and you can change it in Empathy.

Thinking about it though, the lack of persistent feedback is a concern. In the old design, the chat status indicator in the top bar provided a reminder that notifications are disabled (by showing that your status is busy). We don't have that now, so it's possible that you could disable notifications and forget about it.
Comment 4 Matthias Clasen 2013-09-03 12:54:18 UTC
not going to happen for 3.10
Comment 5 Florian Müllner 2013-09-30 15:03:09 UTC
Created attachment 256095 [details] [review]
messageTray: Add 'Notifications' switch to tray menu

According to the designs, the notifications switch was supposed
to move from the user menu to the new message tray menu. However
so far the new system status implementation only removed the old
switch, so add it back in its new place now.
Comment 6 Florian Müllner 2013-09-30 15:04:37 UTC
*** Bug 709045 has been marked as a duplicate of this bug. ***
Comment 7 Allison Karlitskaya (desrt) 2013-09-30 15:53:30 UTC
Can we get this into a 3.10 point release?  It's pretty bad that the old feature was removed before the new one was added to replace it...
Comment 8 Florian Müllner 2013-09-30 15:58:13 UTC
It will require a freeze break request (though the string in question has been around from 3.4 to 3.9.x or so) but sure, if we can get this reviewed ...
Comment 9 drago01 2013-10-01 12:42:20 UTC
Review of attachment 256095 [details] [review]:

Looks good to me and works fine in testing.

And yeah I agree that we should (try) to get this into 3.10.1
Comment 10 Matthias Clasen 2013-10-02 22:29:55 UTC
please request a freeze break
Comment 11 drago01 2013-10-10 06:54:39 UTC
What happened to this?
Comment 12 Florian Müllner 2013-10-10 07:17:43 UTC
Still discussing with the design team ...
Comment 13 Florian Müllner 2013-10-10 21:29:17 UTC
Comment on attachment 256095 [details] [review]
messageTray: Add 'Notifications' switch to tray menu

Attachment 256095 [details] pushed as 6e9a2fe - messageTray: Add 'Notifications' switch to tray menu

The designers were concerned about the busy state being too hidden now (e.g. users can forget that they toggled the switch and miss notifications) - we should address this for 3.12, so leaving the bug open.
Comment 14 javiermon 2013-10-31 12:59:37 UTC
Hi

What about the chat switch that appeared in the design docs? Is that on hold because of the concerns raised by the design team?

thanks,
Comment 15 Jasper St. Pierre (not reading bugmail) 2013-10-31 13:03:04 UTC
It hasn't landed since the design is to launch the Chat app, and the Chat app isn't completed yet.
Comment 16 Carlos Soriano 2014-03-05 19:55:56 UTC
*** Bug 709146 has been marked as a duplicate of this bug. ***
Comment 17 Michael Catanzaro 2014-03-06 00:31:41 UTC
FWIW, I think it's very confusing that disabling notifications changes my chat status to Busy. And the same for vice-versa: I actually missed some important notifications because I didn't realize that setting my Empathy status to Busy would cancel them.

I don't have anything against the behavior of tying notifications to the Busy status, I just wish the behavior would be more obvious. (I don't have any suggestions as to how to do that.)
Comment 18 Allan Day 2014-04-14 08:24:34 UTC
(In reply to comment #17)
> FWIW, I think it's very confusing that disabling notifications changes my chat
> status to Busy. And the same for vice-versa: I actually missed some important
> notifications because I didn't realize that setting my Empathy status to Busy
> would cancel them.
> 
> I don't have anything against the behavior of tying notifications to the Busy
> status, I just wish the behavior would be more obvious. (I don't have any
> suggestions as to how to do that.)

Don't we show a notification when you disable notifications (oh the irony) to explain this?
Comment 19 Allan Day 2014-04-14 08:28:22 UTC
(In reply to comment #13)
...
> The designers were concerned about the busy state being too hidden now (e.g.
> users can forget that they toggled the switch and miss notifications) - we
> should address this for 3.12, so leaving the bug open.

I've filed bug 707073 for this - seems clearer.
Comment 20 Mathieu Bridon 2014-04-14 08:38:19 UTC
(In reply to comment #19)
> (In reply to comment #13)
> ...
> > The designers were concerned about the busy state being too hidden now (e.g.
> > users can forget that they toggled the switch and miss notifications) - we
> > should address this for 3.12, so leaving the bug open.
> 
> I've filed bug 707073 for this - seems clearer.

Wrong bug number?

The number you wrote here is the current bug.
Comment 21 Jasper St. Pierre (not reading bugmail) 2014-04-14 16:56:23 UTC
Bug 728160
Comment 22 Allan Day 2014-04-14 17:07:20 UTC
Oops, sorry!