After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706091 - srtpdec: Shadowed variable causes buffers to be dropped
srtpdec: Shadowed variable causes buffers to be dropped
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.1.3
Other Linux
: Normal normal
: 1.1.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-15 20:59 UTC by GstBlub
Modified: 2013-08-16 18:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that fixes the bug (488 bytes, patch)
2013-08-15 20:59 UTC, GstBlub
committed Details | Review

Description GstBlub 2013-08-15 20:59:15 UTC
Created attachment 251774 [details] [review]
Patch that fixes the bug

A shadowed variable in request_key_with_signal() causes the return value to always be NULL, which causes buffers to be dropped:

0:00:13.564041677 28969  0x82459b0 DEBUG                srtpdec gstsrtpdec.c:448:signal_get_srtp_params:<srtpdec0> Caps received
0:00:13.564167462 28969  0x82459b0 DEBUG                srtpdec gstsrtpdec.c:422:get_stream_from_caps: Got key [0xb390de48]
0:00:13.564234299 28969  0x82459b0 INFO                 srtpdec gstsrtpdec.c:469:init_session_stream:<srtpdec0> Setting RTP policy...
0:00:13.564273772 28969  0x82459b0 INFO                 srtpdec gstsrtpdec.c:472:init_session_stream:<srtpdec0> Setting RTCP policy...
0:00:13.564348414 28969  0x82459b0 DEBUG                srtpdec gstsrtpdec.c:620:request_key_with_signal:<srtpdec0> New stream set with SSRC 2138354990
0:00:13.564398213 28969  0x82459b0 WARN                 srtpdec gstsrtpdec.c:854:gst_srtp_dec_chain:<srtpdec0> Invalid buffer, dropping
0:00:13.564437928 28969  0x82459b0 WARN                 srtpdec gstsrtpdec.c:930:gst_srtp_dec_chain:<srtpdec0:rtcp_sink> Dropping buffer
0:00:14.358516438 28969  0x8245a30 WARN                basesink gstbasesink.c:3264:gst_base_sink_chain_unlocked:<rtpout> warning: Internal data flow problem.
0:00:14.358592719 28969  0x8245a30 WARN                basesink gstbasesink.c:3264:gst_base_sink_chain_unlocked:<rtpout> warning: Received buffer without a new-segment. Assuming timestamps start from 0.
Comment 1 Sebastian Dröge (slomo) 2013-08-16 07:55:03 UTC
Patch looks good but could you please attach it in "git format-patch" style? For that commit it locally (don't forget to tell git your name and mail address) and then call "git format-patch -1".
Comment 2 Sebastian Dröge (slomo) 2013-08-16 07:55:35 UTC
Also we would prefer to have your real name to be put into the git commit instead of just a nickname :)
Comment 3 GstBlub 2013-08-16 17:15:47 UTC
Can you just take credit for it? ;-)
Comment 4 Tim-Philipp Müller 2013-08-16 18:51:27 UTC
Well, I'm okay with taking credit for a removal of some code, but for additions I would also like your real name.

Pushed now, thanks for the patch!

 commit b8f9d674bef05a4020cef6ab2a53b0f346232444
 Author: Tim-Philipp Müller <tim@centricular.net>
 Date:   Fri Aug 16 19:48:03 2013 +0100

    srtpdec: fix buffers being dropped due to shadowed variable
    
    Spotted by gstblub@gmail.com.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706091