After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705733 - Make new system status implementation respect the always-show-universal-access-status setting
Make new system status implementation respect the always-show-universal-acces...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-09 18:20 UTC by Matthias Clasen
Modified: 2013-08-17 15:22 UTC
See Also:
GNOME target: 3.10
GNOME version: ---

Attachments
status: Respect always-show-universal-access-status setting (3.11 KB, patch)
2013-08-13 16:56 UTC, Tanner Doshier 		reviewed Details | Review
status: Respect always-show-universal-access-status setting (3.14 KB, patch)
2013-08-13 17:20 UTC, Tanner Doshier 		accepted-commit_now Details | Review
status: Respect always-show-universal-access-status setting (3.10 KB, patch)
2013-08-13 17:33 UTC, Tanner Doshier 		committed Details | Review

Description Matthias Clasen 2013-08-09 18:20:48 UTC 
This setting was introduced in https://git.gnome.org/browse/gsettings-desktop-schemas/commit/?id=2f73f82a52b3e3aeb3bcbc52d14beb0403cd0b9b and the a11y panel has a switch for it.
Comment 1 Tanner Doshier 2013-08-13 16:56:59 UTC 
Created attachment 251524 [details] [review]
status: Respect always-show-universal-access-status setting
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-08-13 16:58:50 UTC 
Review of attachment 251524 [details] [review]:

::: js/ui/status/accessibility.js
@@ +52,3 @@
+        let a11ySettings = new Gio.Settings({ schema: A11Y_SCHEMA });
+        a11ySettings.connect('changed::' + KEY_ALWAYS_SHOW, Lang.bind(this, function() {
+            this._alwaysShow = !this._alwaysShow;

Why do we need this._alwaysShow? Why not just this._a11ySettings.get_boolean(KEY_ALWAYS_SHOW); ?
Comment 3 Tanner Doshier 2013-08-13 17:20:08 UTC 
Created attachment 251528 [details] [review]
status: Respect always-show-universal-access-status setting

Definitely not a need, just thought to avoid querying the settings
excessively. It's removed.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-08-13 17:22:12 UTC 
Review of attachment 251528 [details] [review]:

One minor nit, otherwise fine.

::: js/ui/status/accessibility.js
@@ +51,3 @@
 
+        this._a11ySettings = new Gio.Settings({ schema: A11Y_SCHEMA });
+        this._a11ySettings.connect('changed::' + KEY_ALWAYS_SHOW, Lang.bind(this, function() {

Lang.bind(this, this._queueSyncMenuVisibility)
Comment 5 Tanner Doshier 2013-08-13 17:33:05 UTC 
Created attachment 251529 [details] [review]
status: Respect always-show-universal-access-status setting

Fixed.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-08-13 17:35:34 UTC 
Review of attachment 251529 [details] [review]:

OK.
Comment 7 Matthias Clasen 2013-08-16 13:05:26 UTC 
Attachment 251529 [details] pushed as c95ec8e - status: Respect always-show-universal-access-status setting
Comment 8 Magdalen Berns (irc magpie) 2013-08-17 15:22:17 UTC 
Good work