After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703959 - [network] Toggling a VPN connection to use it only for resources on its network doesn't count as a change
[network] Toggling a VPN connection to use it only for resources on its netwo...
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 707511 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-07-10 16:52 UTC by David Strauss
Modified: 2013-09-04 21:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description David Strauss 2013-07-10 16:52:07 UTC 
Editing a VPN connection and checking/unchecking the "Use this connection only for resources on its network" doesn't count as a change worthy of enabling the "Apply" button.

A current workaround is making another change and then reversing the other change, which then allows applying the form.
Comment 1 Jiri Klimes 2013-07-19 11:18:43 UTC 
This is an issue in network module of gnome-control-center.
See also bug https://bugzilla.redhat.com/show_bug.cgi?id=984218
Comment 2 pogliamarci 2013-08-29 21:23:23 UTC 
Is there any update about the status of this bug?

This is present as of gnome-control-center 3.8.4.1-2 on ArchLinux.

When I toggle the checkbox, the "Apply" button is enabled, but the change is not saved (the checkbox has no effect, the default route doesn't change, and when reopening the configuration window the checkbox is unchecked\checked again). 

The same checkbox on nm-connection-editor works, and is reflected by the control-center GUI.
Comment 3 pogliamarci 2013-08-29 21:24:39 UTC 
Related bug: https://bugzilla.redhat.com/show_bug.cgi?id=952224
Comment 4 pogliamarci 2013-08-29 22:17:01 UTC 
If I change a route, change the checkbox status, and then trigger the "Apply" button, it's all working -- the default route is set up correctly.

So I think that in this case the checkbox is not triggering the settings update.

I currently cannot clone and compile the sources. Could be helpful to add in in panels/network/connection-editor/ce-page-ip4.c (in the function connect_ip4_page) the line

   g_signal_connect (page->never_default, "toggled", 
                     G_CALLBACK (ce_page_changed), page);

or something similar, so to raise the CHANGED signal when the checkbox is toggled?

Sorry again for the multiple post :)
Comment 5 David Strauss 2013-09-03 05:02:01 UTC 
For anyone interested, here's the commit that fixes the issue:
https://git.gnome.org/browse/gnome-control-center/commit/?id=e165efc6f9970eed601b17d9f489c4243069a76f
Comment 6 Giovanni Campagna 2013-09-04 21:54:59 UTC 
*** Bug 707511 has been marked as a duplicate of this bug. ***