After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702825 - Slider trough should have rounded ends
Slider trough should have rounded ends
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-21 15:56 UTC by Allan Day
Modified: 2013-06-25 13:51 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8


Attachments
slider: Extend the trough to the allocation extents (1.96 KB, patch)
2013-06-21 18:58 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
slider: Use clutter_cairo_set_source_color (3.19 KB, patch)
2013-06-21 18:58 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
slider: Add rounded ends to sliders (2.31 KB, patch)
2013-06-21 18:58 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
screenshot (14.20 KB, image/png)
2013-06-24 10:39 UTC, Allan Day
  Details
slider: Add rounded ends to sliders (2.73 KB, patch)
2013-06-24 16:32 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
screenshot (14.29 KB, image/png)
2013-06-25 10:34 UTC, Allan Day
  Details

Description Allan Day 2013-06-21 15:56:52 UTC
Right now the ends of the trough are square. They should be rounded:

https://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/volume.png

I tried setting -slider-radius from the theme, but that didn't work. Is there a property for this? If there's not, can we have one please? :)
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-06-21 18:58:08 UTC
Created attachment 247482 [details] [review]
slider: Extend the trough to the allocation extents

This aligns the edge of the slider with the allocation of items
under it, which is what we want to happen in the new aggregate
menu.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-06-21 18:58:12 UTC
Created attachment 247483 [details] [review]
slider: Use clutter_cairo_set_source_color

This cuts down on the denseness of the code.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-06-21 18:58:15 UTC
Created attachment 247484 [details] [review]
slider: Add rounded ends to sliders
Comment 4 Allan Day 2013-06-24 10:39:19 UTC
Created attachment 247624 [details]
screenshot

Thanks for the patches Jasper.

This looks good, but I would increase the radius - it should look like a half-circle (in the mockups the radius is 1.5). Maybe it would be good to have the radius in the theme?
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-06-24 16:32:43 UTC
Created attachment 247656 [details] [review]
slider: Add rounded ends to sliders

--

It is drawing a perfect circle. It's just that the stroke goes *outside*
the bounds of the slider, so it gets cut off, making the shape not look
like a circle.

Here's one potential solution: add some padding to the slider so that
we don't bump the stroke into the edge of the texture.

Does this look better?
Comment 6 drago01 2013-06-24 19:17:34 UTC
Review of attachment 247482 [details] [review]:

LG.
Comment 7 drago01 2013-06-24 19:18:30 UTC
Review of attachment 247483 [details] [review]:

OK.
Comment 8 drago01 2013-06-24 19:20:16 UTC
Review of attachment 247656 [details] [review]:

Looks good, fine to push with design ack,
Comment 9 Jasper St. Pierre (not reading bugmail) 2013-06-24 19:32:41 UTC
Attachment 247482 [details] pushed as a01469f - slider: Extend the trough to the allocation extents
Attachment 247483 [details] pushed as 8d47afb - slider: Use clutter_cairo_set_source_color


Let's push these two for now.
Comment 10 Allan Day 2013-06-25 10:34:36 UTC
Created attachment 247717 [details]
screenshot

I'm running this with the latest patches, and it still doesn't look fully rounded.
Comment 11 Jasper St. Pierre (not reading bugmail) 2013-06-25 13:50:13 UTC
Attachment 247656 [details] pushed as 109b29a - slider: Add rounded ends to sliders


After IRC discussion, we discussed that, yes, it is rounded.
Comment 12 Allan Day 2013-06-25 13:51:39 UTC
/me books an appointment at the optician