After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702564 - tons of warning messages in journalctl ... meta_screen_get_monitor_geometry: assertion `monitor >= 0 ...' failed
tons of warning messages in journalctl ... meta_screen_get_monitor_geometry: ...
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-18 13:55 UTC by Matěj Cepl
Modified: 2013-06-24 15:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: Make sure override_redirect window have correct monitor info (1.97 KB, patch)
2013-06-24 07:54 UTC, drago01
none Details | Review
window: Make sure override_redirect window have correct monitor info (1.48 KB, patch)
2013-06-24 07:57 UTC, drago01
none Details | Review
window: Make sure override_redirect window have correct monitor info (2.04 KB, patch)
2013-06-24 15:22 UTC, drago01
none Details | Review
window: Make sure override_redirect window have correct monitor info (2.03 KB, patch)
2013-06-24 15:28 UTC, drago01
committed Details | Review

Description Matěj Cepl 2013-06-18 13:55:15 UTC
Description of problem:
When I run journalctl -f as normal user I get thousands (new at least in second internal) messages like

Jun 17 23:16:57 wycliff.ceplovi.cz /etc/gdm/Xsession[1704]: Window manager warning: Log level 8: meta_screen_get_monitor_geometry: assertion `monitor >= 0 ...' failed

Version-Release number of selected component (if applicable):
gnome-shell-3.8.2-4.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.run journalctl -f
2.
3.

Actual results:
thousands of lines like shown above

Expected results:
no warnings, useful log

Also filed as https://bugzilla.redhat.com/show_bug.cgi?id=975453
Comment 1 drago01 2013-06-23 21:18:40 UTC
I have looked at this a bit ... just to confirm my theory do have any (legacy) icons in the tray?

They are off screen while the tray is hidden causing them to have an uninitialized monitor number.
Comment 2 drago01 2013-06-23 21:21:52 UTC
And do you have more than one monitor?
Comment 3 Matěj Cepl 2013-06-24 05:17:04 UTC
a) not sure what do you mean as a tray; I use plain gnome-shell (not the Classic mode),
b) yes, I have external monitor and use it in dual-monitor (non-mirroring) setup.
Comment 4 drago01 2013-06-24 07:54:01 UTC
Created attachment 247599 [details] [review]
window: Make sure override_redirect window have correct monitor info

We need to update window->monitor on override_redirect windows as well, other
wise they may end up with an invalid struct which triggers and assert when
meta_window_is_monitor_sized is called.

---
OK, this has nothing to do with offscreen tray icons. We don't update the monitor info on override redirect windows (which the tray icons are which is why I have suspected them) when the monitor / screen size changes.

This patch fixes this.
Comment 5 drago01 2013-06-24 07:55:46 UTC
(In reply to comment #3)
> a) not sure what do you mean as a tray; I use plain gnome-shell (not the
> Classic mode),

I mean the icons (like pidgin, xchat, dropbox in the message tray).

> b) yes, I have external monitor and use it in dual-monitor (non-mirroring)
> setup.

OK.

Anyway found the bug see patch.
Comment 6 drago01 2013-06-24 07:57:11 UTC
Created attachment 247600 [details] [review]
window: Make sure override_redirect window have correct monitor info

We need to update window->monitor on override_redirect windows as well, other
wise they may end up with an invalid struct which triggers and assert when
meta_window_is_monitor_sized is called.
Comment 7 drago01 2013-06-24 15:22:09 UTC
Created attachment 247651 [details] [review]
window: Make sure override_redirect window have correct monitor info

We need to update window->monitor on override_redirect windows as well, other
wise they may end up with an invalid struct which triggers and assert when
meta_window_is_monitor_sized is called.
Comment 8 drago01 2013-06-24 15:28:18 UTC
Created attachment 247652 [details] [review]
window: Make sure override_redirect window have correct monitor info

We need to update window->monitor on override_redirect windows as well, other
wise they may end up with an invalid struct which triggers and assert when
meta_window_is_monitor_sized is called.
Comment 9 Florian Müllner 2013-06-24 15:30:21 UTC
Review of attachment 247652 [details] [review]:

OK, this versions LGTM
Comment 10 drago01 2013-06-24 15:32:40 UTC
Attachment 247652 [details] pushed as 8ab136b - window: Make sure override_redirect window have correct monitor info