Created attachment 246153 [details] [review]
documents: Show thumbnails for Google Documents

Review of attachment 246153 [details] [review]:

Thanks! This looks great, I just have one minor comment. Feel free to push with that change.

::: src/documents.js
@@ +359,3 @@
     },
 
+    createIcon: function(callback) {

Can you rename this to createThumbnail() instead?

(In reply to comment #2)
> Review of attachment 246153 [details] [review]:
> 
> Thanks! This looks great, I just have one minor comment. Feel free to push with
> that change.
> 
> ::: src/documents.js
> @@ +359,3 @@
>      },
> 
> +    createIcon: function(callback) {
> 
> Can you rename this to createThumbnail() instead?

Done.

Created attachment 246237 [details] [review]
documents: Show thumbnails for Google Documents

Thanks for the review. Does it make sense to have it in gnome-3-8 given that the bug was filed against it?

Since you backported the gvfs patch as well, I think it does. Feel free to push there as well.

On a freshly installed system where ~/.cache/thumbnails/normal doesn't exist and there is no local content, creation of thumbnails for Google documents will fail. This is because we are not creating the directory before trying to download the thumbnails.

Created attachment 257832 [details] [review]
documents: The directory must exist before we fetch the thumbnail

Review of attachment 257832 [details] [review]:

Makes sense to me.

Comment on attachment 257832 [details] [review]
documents: The directory must exist before we fetch the thumbnail

Thanks for the review!