After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694346 - pbutils, typefinding: improve handling of MVC/SVC H.264 streams
pbutils, typefinding: improve handling of MVC/SVC H.264 streams
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-21 10:09 UTC by sreerenj
Modified: 2013-02-22 00:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pbutils: add more H.264 profile/level extractions. (1.21 KB, patch)
2013-02-21 10:09 UTC, sreerenj
committed Details | Review
typefindfunctions: recognize SVC and MVC nal units as a part of h264 stream. (2.58 KB, patch)
2013-02-21 10:10 UTC, sreerenj
committed Details | Review

Description sreerenj 2013-02-21 10:09:37 UTC
Created attachment 237023 [details] [review]
pbutils: add more H.264 profile/level extractions.

Adding 2 patches: first one to pbutils and second one to typerfinder.

patch1: Extract Stereo High profile and Multiview high profile.

patch2: Ensure the detection of svc and mvc as a part of h264 stream.Once the typefinder detect a subset_sequence_parameter_set(ssps),then each nal unit with type 14 or 20 should be detected as a part of h264 stream thereafter.

The patch2 will help to negotiate the MVC bistreams in playbin. We can even see the decoded output with avdec_h264 since these decoders are decoding the base view and omitting nal nuits with type (14,15 and 20) gracefully. 
For S3D bitstreams ,currently playbin is just failing with error message of
"Could not determine type of stream".
Comment 1 sreerenj 2013-02-21 10:10:38 UTC
Created attachment 237024 [details] [review]
typefindfunctions: recognize SVC and MVC nal units as a part of h264 stream.
Comment 2 Tim-Philipp Müller 2013-02-21 12:30:29 UTC
Comment on attachment 237024 [details] [review]
typefindfunctions: recognize SVC and MVC nal units as a part of h264 stream.

Thanks, pushed with minor cosmetic changes (add braces and keep comment block where it belongs):

commit 9791f0aaf164828df7e112ca23ccd88ba0a7f45c
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Thu Feb 21 11:38:45 2013 +0200

    typefindfunctions: recognize SVC and MVC nal units in h264 streams
    
    Ensure the detection of svc and mvc as a part of h264 stream.
    Once the typefinder detect a subset_sequence_parameter_set(ssps),
    then each nal unit with type 14 or 20 should be detected as a
    part of h264 stream thereafter.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=694346
Comment 3 Tim-Philipp Müller 2013-02-22 00:00:32 UTC
Thanks!

 commit 0abec3f89a0a50906eda7ca547541948d74a80fa
 Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
 Date:   Wed Feb 20 18:36:20 2013 +0200

    pbutils: recognise more H.264 profiles/levels
    
    Add profile/level extraction for Multiview High profile
    and Stereo High profile.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=694346