After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694257 - pulsesink: Update segdone periodically
pulsesink: Update segdone periodically
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-20 11:03 UTC by Arun Raghavan
Modified: 2013-03-22 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pulsesink: Update segdone periodically (2.24 KB, patch)
2013-02-20 11:03 UTC, Arun Raghavan
committed Details | Review

Description Arun Raghavan 2013-02-20 11:03:30 UTC
This makes sure that we update segdone based on the read index received
during latency updates. As the comment notes, we make some compromises
to deal with the fact that segdone is a segment multiple, while the read
index offers finer granularity. The updates are also not very often
(100ms since that is how often automatic timing updates are provided).

All this is required for the baseaudiosink sample alignment code to work
at all.
Comment 1 Arun Raghavan 2013-02-20 11:03:33 UTC
Created attachment 236910 [details] [review]
pulsesink: Update segdone periodically
Comment 2 Wim Taymans 2013-02-22 07:54:22 UTC
looks like a good thing to do, please commit.
Comment 3 Arun Raghavan 2013-02-23 03:58:27 UTC
The following fixes have been pushed:
Comment 4 Tim-Philipp Müller 2013-03-22 10:44:24 UTC
commit 35f3bea55888315ea477b16cfec19666962f2c70
Author: Arun Raghavan <arun.raghavan@collabora.co.uk>
Date:   Tue Nov 20 12:14:07 2012 +0530

    pulsesink: Update segdone periodically
    
    This makes sure that we update segdone based on the read index received
    during latency updates. As the comment notes, we make some compromises
    to deal with the fact that segdone is a segment multiple, while the read
    index offers finer granularity. The updates are also not very often
    (100ms since that is how often automatic timing updates are provided).
    
    All this is required for the baseaudiosink sample alignment code to work
    at all.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=694257