GNOME Bugzilla – Bug 691900
offer system actions in shell search
Last modified: 2017-08-22 11:18:05 UTC
One thing I've seen come up in user testing is a roadblock when the overview search isn't able to find a system action. This is shocking to people because it appears the shell search can find anything. For example, many of the actions in the "user menu" are not found by search: Power Off, Lock, Log Out, maybe others. One idea is that we can have the shell fake up application/action targets in the search results for these things. They wouldn't appear in the application view but could still appear in the results. They could be differentiated from applications by their appearance - being symbolic and uncolored.
Should they be grid results, or list results?
(In reply to comment #1) > Should they be grid results, or list results? Grid, I'd say.
*** Bug 724805 has been marked as a duplicate of this bug. ***
Hi, I am interested in working on this bug. So please can you assign this bug to me? Thanks in advance, Regards, Anup
We don't do bug assignments lie(In reply to comment #4) > Hi, > > I am interested in working on this bug. So please can you assign this bug to > me? Hi Anup - it's great that you want to work on this! We usually don't do bug assignments - your comment is enough to mark that you are interested in it, and let people know to contact you if they are interested in the status.
(In reply to Anup from comment #4) > I am interested in working on this bug. Hello Anup, have you made any progress?
I would like to hear news regarding this bug. This kind of feature would make me much more productive.
A visual treatment for this feature can be found here: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/shell/search/search-list-layout.png
As this came up earlier: This bug has been part of Rares' GSoC project, but we agreed to do code reviews on our gitlab test instance to get familiar with the new workflow.
Created attachment 358117 [details] [review] system: prevent leaving the overview on system actions Due to the fact that leaving the overview is an old behavior it is not deprecated and unnecessary for most actions, except the settings one. The settings system action opens an app, therefore leaving the overview makes sense.
Created attachment 358118 [details] [review] system: Split out system actions to its own module In anticipation of showing the system actions in the search results, it is fit to move action specific code to its own module in order to reuse it.
Created attachment 358119 [details] [review] systemActions: Store properties in a map It is more convenient and structured to use a map in order to store system actions and their properties. The current changes are an improvement over the classic instance properties because it provides clarity and ease of management.
Created attachment 358120 [details] [review] systemActions: Make actions searchable Every action has specific associated terms that identify that action and show it in the search results. Methods to match the actions as well as getting properties of specific actions are needed in order to provide a way of using the actions.
Created attachment 358121 [details] [review] appDisplay: Include system actions in search results The way system actions are displayed in the search results is by appending them at the end of the list returned by the ApplicationProvider.
Review of attachment 358117 [details] [review]: The commit message needs a bit of work - at the very least: - nothing is "prevented", leaving the overview is just no longer part of the action. So something like: "system: Don't leave overview when activating most items" - "it is not deprecated" => "it is now deprecated" Not that 'deprecated' makes a lot of sense in that context; better mention that the previous behavior was done for technical reasons that no longer apply So my take would be along the lines of: system: Don't leave overview when activating most items The current behavior wasn't designed, but was introduced in commit 84efaac52b to work around technical limitations when we were still using external tools like gnome-screensaver or gnome-session-quit to handle the actions. Those limitations are long gone, so it makes sense to make the actions consistent with the corresponding keyboard shortcuts: Leave the overview when launching an application, and leave it alone otherwise.
Review of attachment 358118 [details] [review]: OK
Review of attachment 358119 [details] [review]: The commit message doesn't make sense - you'll have a hard time arguing that this._actions.get(POWER_OFF_ACTION_ID).available is clearer and more convenient than this._canPowerOff This only makes sense in the context of the future search feature, so the commit message needs to mention it.
Review of attachment 358120 [details] [review]: ::: js/misc/systemActions.js @@ +97,3 @@ this._actions.set(POWER_OFF_ACTION_ID, + { // Translators: The name of the power-off action in search + name: _("Power off"), As suggested by Piotr on gnome-i18n, it is a good idea to add context here: C_("search-result", "Power off")
Review of attachment 358121 [details] [review]: Please remember to push the style changes to gnome-shell-sass and update the submodule before pushing this commit.
Created attachment 358127 [details] [review] system: Don't leave overview when activating most items Updated commit message.
Created attachment 358128 [details] [review] systemActions: Store properties in a map Updated commit message.
Created attachment 358129 [details] [review] systemActions: Make actions searchable Add context to strings
Attachment 358118 [details] pushed as 9c3b332 - system: Split out system actions to its own module Attachment 358121 [details] pushed as 52f6047 - appDisplay: Include system actions in search results Attachment 358127 [details] pushed as 7d95275 - system: Don't leave overview when activating most items Attachment 358128 [details] pushed as b4b1caf - systemActions: Store properties in a map Attachment 358129 [details] pushed as 595065b - systemActions: Make actions searchable