After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690300 - Settings of DAP sources are not remembered between syncs
Settings of DAP sources are not remembered between syncs
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device (general)
git master
Other Linux
: Normal normal
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-16 17:48 UTC by Andrés G. Aragoneses (IRC: knocte)
Modified: 2012-12-16 21:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gconf-editor screenshot (358.41 KB, image/png)
2012-12-16 17:48 UTC, Andrés G. Aragoneses (IRC: knocte) 		  Details
Proposed patch v1 (991 bytes, patch)
2012-12-16 17:52 UTC, Andrés G. Aragoneses (IRC: knocte) 		committed Details | Review

Description Andrés G. Aragoneses (IRC: knocte) 2012-12-16 17:48:40 UTC 
Created attachment 231660 [details]
gconf-editor screenshot

So in theory we have the infrastructure to persist settings about our DAP sources (such as the "sync_entire_library" setting).

However, they are only saved for the sync session. The reason is that we were using the property "Uuid" of the "IDevice" interface which, it turns out, is different every time the device gets connected.

I'm attaching a screenshot of the consequence of this (the same device being stored in many different subtrees in GConf).

What the end user notices is that the setting is never remembered.

Attaching a patch soon.
Comment 1 Andrés G. Aragoneses (IRC: knocte) 2012-12-16 17:52:07 UTC 
Created attachment 231661 [details] [review]
Proposed patch v1
Comment 2 Andrés G. Aragoneses (IRC: knocte) 2012-12-16 21:57:46 UTC 
Comment on attachment 231661 [details] [review]
Proposed patch v1

http://git.gnome.org/browse/banshee/commit/?id=c4cbfba85f3e4d17db81a2a5b799d943b1edcbdd
Comment 3 Andrés G. Aragoneses (IRC: knocte) 2012-12-16 21:58:12 UTC 
Thanks for the quick review Alex!