After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688870 - mpegtsmux: does not propagate flow status
mpegtsmux: does not propagate flow status
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.0.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-22 13:36 UTC by Krzysztof Konopko
Modified: 2012-11-28 18:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch with the accompanying test. (2.79 KB, patch)
2012-11-22 13:36 UTC, Krzysztof Konopko
committed Details | Review

Description Krzysztof Konopko 2012-11-22 13:36:11 UTC
mpegtsmux_collected_buffer() ignores flow status returned from mpegtsmux_push_packets (). This breaks the propagation of the flow status upstream.
Comment 1 Krzysztof Konopko 2012-11-22 13:36:52 UTC
Created attachment 229633 [details] [review]
Proposed patch with the accompanying test.
Comment 2 Tim-Philipp Müller 2012-11-23 00:16:51 UTC
Thanks for the patch, fixed up C++ comments and the buffer leaks:

 commit 76b8e8be513d9f439549ecb5d1cbf7aa2da8e658
 Author: Krzysztof Konopko <krzysztof.konopko@youview.com>
 Date:   Thu Nov 22 10:57:25 2012 +0000

    mpegtsmux: propagate flow returns
    
    And add a unit test.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=688870


PS: would be great if you could submit the patch in git format-patch format next time.
Comment 3 Krzysztof Konopko 2012-11-23 11:11:22 UTC
> PS: would be great if you could submit the patch in git format-patch format
next time.

Silly me. I used gitk to export the patch rather than git diff. Will do better next time :)
Comment 4 Tim-Philipp Müller 2012-11-23 11:44:50 UTC
I really did mean git format-patch. When you have created your commit(s), you do:

 $ git format-patch -1
 0001-mpegtsmux-propagate-flow-returns.patch

And it will create numbered .patch files, one for each commit (-1 is for the last commit, -2 for the last two commits, etc.). That file is the one to attach in bugzilla. We can then apply it using

 $ git am 0001*.patch

(It will look like a mail with a few mail headers, as it happens, incl. a sender date and subject line).

(There are also bugzilla helpers for git somewhere that allow you to directly file a bug from a commit).