After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687932 - Add schemas for notification filtering
Add schemas for notification filtering
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 685926 685928
 
 
Reported: 2012-11-08 18:10 UTC by Giovanni Campagna
Modified: 2012-12-20 21:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add schemas for notification filtering (4.37 KB, patch)
2012-11-08 18:11 UTC, Giovanni Campagna
accepted-commit_now Details | Review
Add schemas for notification filtering (4.38 KB, patch)
2012-11-30 17:28 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2012-11-08 18:10:56 UTC
For the 3.8 feature, add schemas for notification settings, both a master
schema and one for individual applications.
These will be used by gnome-shell and gnome-control-center.
Comment 1 Giovanni Campagna 2012-11-08 18:11:00 UTC
Created attachment 228498 [details] [review]
Add schemas for notification filtering
Comment 2 Bastien Nocera 2012-11-18 10:39:50 UTC
Review of attachment 228498 [details] [review]:

Looks good otherwise.

::: schemas/org.gnome.desktop.notifications.gschema.xml.in.in
@@ +56,3 @@
+      <_description>
+        Whether notification banners for this application are shown or not. Does not
+        affect summary mode.

What's summary mode?
Could you expand?
Comment 3 Bastien Nocera 2012-11-29 10:04:34 UTC
Can you update the patch, Giovanni?
Comment 4 Giovanni Campagna 2012-11-30 17:28:11 UTC
Created attachment 230311 [details] [review]
Add schemas for notification filtering

For the 3.8 feature, add schemas for notification settings, both a master
schema and one for individual applications.
These will be used by gnome-shell and gnome-control-center.

I could not find a better way to describe that.
Comment 5 Bastien Nocera 2012-12-03 13:33:54 UTC
Review of attachment 230311 [details] [review]:

::: schemas/org.gnome.desktop.notifications.gschema.xml.in.in
@@ +43,3 @@
+    </key>
+
+    <key name="enable-sound" type="b">

enable-sound-alerts

@@ +47,3 @@
+      <_summary>Enable sound</_summary>
+      <_description>
+        Whether notifications should be accompained by alert sounds.

"accompanied" and "sound alerts".

@@ +80,3 @@
+      <_summary>Be resident in the lock screen</_summary>
+      <_description>
+        Whether notifications from this application are shown as resident (fully and with details) when the screen is locked.

I'll expand the definition of resident here.
Comment 6 Bastien Nocera 2012-12-03 13:41:30 UTC
Pushed a patch with slightly revised descriptions and key names.
Please check that the descriptions are factually correct too.
Comment 7 Giovanni Campagna 2012-12-03 17:16:29 UTC
There is one slight incorrectness.
resident-in-lock-screen may be a bad name, but it refers to the fact that in the current implementation resident notifications are shown individually and fully (with details, action buttons and images), instead of being grouped by source, and resident-in-lock-screen forces notifications that are not normally resident to get that treatment.
In the control center panel, it is bound to the "Show details in the lock screen" switch.
Comment 8 Bastien Nocera 2012-12-20 07:46:49 UTC
(In reply to comment #7)
> There is one slight incorrectness.
> resident-in-lock-screen may be a bad name, but it refers to the fact that in
> the current implementation resident notifications are shown individually and
> fully (with details, action buttons and images), instead of being grouped by
> source, and resident-in-lock-screen forces notifications that are not normally
> resident to get that treatment.
> In the control center panel, it is bound to the "Show details in the lock
> screen" switch.

Does "Whether notifications from this application will be shown individually in full (with details, action buttons and images) in the lock screen." sound good?
Comment 9 Giovanni Campagna 2012-12-20 21:41:31 UTC
(In reply to comment #8)
> 
> Does "Whether notifications from this application will be shown individually in
> full (with details, action buttons and images) in the lock screen." sound good?

I guess that might work.
Comment 10 Bastien Nocera 2012-12-20 21:52:33 UTC
Done.