After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686657 - Highlight currently playing radio station
Highlight currently playing radio station
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Internet Radio
unspecified
Other Linux
: Normal trivial
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-22 18:12 UTC by Alex Willmy
Modified: 2013-01-20 23:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (1.50 KB, patch)
2012-10-22 20:31 UTC, Alex Willmy 		committed Details | Review

Description Alex Willmy 2012-10-22 18:12:58 UTC 
To be consistent with the rest of Banshee's UI the currently playing radio station entry should be highlighted with an icon and bold caption.
Comment 1 Alex Willmy 2012-10-22 20:31:19 UTC 
Created attachment 227021 [details] [review]
Proposed fix

Proposed patch for the issue
Comment 2 Andrés G. Aragoneses (IRC: knocte) 2013-01-20 23:09:12 UTC 
Comment on attachment 227021 [details] [review]
Proposed fix

Thanks for the patch! I pushed this with a minor change, I removed this bit:

ServiceManager.PlayerEngine.CurrentState != PlayerState.Contacting &&

Even though it's well intentioned, I've been playing with that added and removed, and it is a better UI experience to show the bold text for the row of the internet radio being started as soon as possible after the user requests it, even if it's not playing yet. If the radio ends up being unavailable, the icon will change immediately with an "[X]" on it so at least the user knows that Banshee tried to connect to it.

http://git.gnome.org/browse/banshee/commit/?id=b1a16f03295c184c917032e574708eb462ba31a8
Comment 3 Andrés G. Aragoneses (IRC: knocte) 2013-01-20 23:10:21 UTC 
And sorry for the delay reviewing it!

This problem has been fixed in the development version. The fix will be available in the next software release. Thank you for your bug report.