After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686474 - The active area of tray items should extend to the edge of the screen.
The active area of tray items should extend to the edge of the screen.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-19 15:35 UTC by Allan Day
Modified: 2012-10-26 14:33 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8


Attachments
message-tray: Restore Fittsability of summary items (2.17 KB, patch)
2012-10-26 04:13 UTC, Florian Müllner
needs-work Details | Review
message-tray: Restore Fittsability of summary items (2.17 KB, patch)
2012-10-26 13:48 UTC, Florian Müllner
committed Details | Review

Description Allan Day 2012-10-19 15:35:10 UTC
If I try to click on a tray item and have the mouse pointer against the bottom of the screen, nothing happens - there is a gap between the tray item and the bottom of the screen. Visually, this gap is fine, but it should respond to clicks.
Comment 1 Florian Müllner 2012-10-26 04:13:23 UTC
Created attachment 227321 [details] [review]
message-tray: Restore Fittsability of summary items

The reactive area of tray items should extend to the screen edge. This
regressed when implementing the new tray design, make it work again.
Comment 2 Rui Matos 2012-10-26 13:24:20 UTC
Review of attachment 227321 [details] [review]:

Looks fine but I would squash the following on this patch so that there's no "dead" gap between the buttons:

diff --git a/data/theme/gnome-shell.css b/data/theme/gnome-shell.css
index 2aec8bb..2e4b82d 100644
--- a/data/theme/gnome-shell.css
+++ b/data/theme/gnome-shell.css
@@ -1432,11 +1432,10 @@ StScrollBar StButton#vhandle:active {
 
 #summary-mode {
     height: 72px;
-    spacing: 10px;
 }
 
 .summary-source-button {
-    padding: 6px 0 6px 0;
+    padding: 6px 3px 6px 3px;
 }
 
 .summary-source-button:last-child:ltr {
Comment 3 Florian Müllner 2012-10-26 13:48:24 UTC
Created attachment 227359 [details] [review]
message-tray: Restore Fittsability of summary items

(In reply to comment #2)
> Looks fine but I would squash the following on this patch so that there's no
> "dead" gap between the buttons:
> 
> [...]
> 
>  .summary-source-button {
> -    padding: 6px 0 6px 0;
> +    padding: 6px 3px 6px 3px;
>  }

I'm assuming s/3/5/ to keep the existing spacing.
Comment 4 Rui Matos 2012-10-26 13:52:23 UTC
Review of attachment 227359 [details] [review]:

(In reply to comment #3)
> I'm assuming s/3/5/ to keep the existing spacing.

I think it looks better if the inter button gap is the same size as the gap to the top and bottom. Ask a designer and push. Should go to the 3.6 branch too IMO.
Comment 5 Jakub Steiner 2012-10-26 14:28:52 UTC
Agreed on the horizontal spacing.
Comment 6 Florian Müllner 2012-10-26 14:33:04 UTC
Attachment 227359 [details] pushed as 9396849 - message-tray: Restore Fittsability of summary items