After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684411 - rtsp: range in SDP formatted according to locale
rtsp: range in SDP formatted according to locale
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.0.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-19 23:29 UTC by Kasper Holtze
Modified: 2012-10-12 23:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtsprange: fix creating and parsing range floating-point (2.00 KB, patch)
2012-09-20 12:48 UTC, Tim-Philipp Müller
committed Details | Review

Description Kasper Holtze 2012-09-19 23:29:16 UTC
When using a locale where decimal separator is not "." but ",", range is reported incorrectly which causes RTSP-streams to be non-seekable.

Example with danish locale:
a=range:npt=0,000000-5263,319000

When changed to US it outputs the following (correctly):
a=range:npt=0.000000-5263.319000
Comment 1 Tim-Philipp Müller 2012-09-20 12:48:13 UTC
Created attachment 224830 [details] [review]
rtsprange: fix creating and parsing range floating-point
Comment 2 Wim Taymans 2012-10-10 10:04:57 UTC
commit please
Comment 3 Tim-Philipp Müller 2012-10-12 23:54:19 UTC
Pushed patch in slightly modified form, so that we accept floating point values with a comma as well now, in case the other side is buggy.


commit 336842d35cf7e5d68c7f71d961d1fff8c19d49e9
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Thu Sep 20 01:07:08 2012 +0100

    rtsprange: fix formatting and parsing of range floating-point values
    
    Other locales might use a comma instead of a floating point
    for floats, which might lead to parsing errors.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=684411