After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684306 - minor improvements to the not responding dialog
minor improvements to the not responding dialog
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-18 16:09 UTC by William Jon McCann
Modified: 2012-10-16 12:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (18.96 KB, image/png)
2012-09-18 16:09 UTC, William Jon McCann
  Details
Minor improvements to the not responding dialog (1.20 KB, patch)
2012-09-18 16:10 UTC, William Jon McCann
committed Details | Review
screenshot (after) (14.99 KB, image/png)
2012-09-18 16:11 UTC, William Jon McCann
  Details
utils: Request a modal dialog when transient_for is set (992 bytes, patch)
2012-09-18 19:43 UTC, Florian Müllner
committed Details | Review
util: Optionally pass an icon_name to meta_show_dialog() ... (2.80 KB, patch)
2012-09-18 21:06 UTC, Florian Müllner
committed Details | Review
delete: Unbreak string freeze (1.08 KB, patch)
2012-09-19 09:21 UTC, Florian Müllner
committed Details | Review
Revert "delete: Unbreak string freeze" (1013 bytes, patch)
2012-09-19 09:23 UTC, Florian Müllner
committed Details | Review
lighter symbolic (14.99 KB, image/png)
2012-09-19 09:28 UTC, Jakub Steiner
  Details
util: Guard against older zenity versions (2.07 KB, patch)
2012-09-19 12:35 UTC, Florian Müllner
committed Details | Review

Description William Jon McCann 2012-09-18 16:09:35 UTC
Created attachment 224640 [details]
screenshot

Longer term we probably want to change the way we handle not responding windows. But as long as we have the current one we may as well make it look a bit better.

It has a few problems.

 * Unmotivated use of italics
 * Two different fonts/sizes used in the heading
 * Strangely large
 * It displays the window title instead of the application name

The first two are easy to fix at least.
Comment 1 William Jon McCann 2012-09-18 16:10:50 UTC
Created attachment 224641 [details] [review]
Minor improvements to the not responding dialog
Comment 2 William Jon McCann 2012-09-18 16:11:16 UTC
Created attachment 224642 [details]
screenshot (after)
Comment 3 William Jon McCann 2012-09-18 16:14:34 UTC
Also it would be nice if the dialog appeared as a window modal dialog.
Comment 4 Florian Müllner 2012-09-18 19:43:46 UTC
Created attachment 224664 [details] [review]
utils: Request a modal dialog when transient_for is set
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-09-18 19:49:59 UTC
Review of attachment 224641 [details] [review]:

This will violate string freeze. I wonder if doing something like:

    g_strdup_printf("“%s”", window_title);

to get around that would be translatable. If you want to ask for a freeze break, go ahead. ACN if you're doing that.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-09-18 19:50:32 UTC
Review of attachment 224664 [details] [review]:

Makes sense.
Comment 7 Florian Müllner 2012-09-18 21:06:12 UTC
Created attachment 224675 [details] [review]
util: Optionally pass an icon_name to meta_show_dialog() ...

... and use a sad face in the force-quit dialog.
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-09-18 21:10:38 UTC
Review of attachment 224675 [details] [review]:

I'd reverse the commit message.

delete: Display a sad face in the force-quit dialog.

Code looks fine.
Comment 9 William Jon McCann 2012-09-19 02:44:37 UTC
I'm leaning towards using sad-face-symbolic but I'd like to hear Jakub's opinion.
Comment 10 Florian Müllner 2012-09-19 09:21:59 UTC
Created attachment 224718 [details] [review]
delete: Unbreak string freeze

Quotes should definitively part of the translation, but we are in
string freeze now - revert this when we get a string freeze approval
or after the freeze ends.

I didn't see a string freeze request, so let's go with this for now.
Comment 11 Florian Müllner 2012-09-19 09:22:29 UTC
Attachment 224641 [details] pushed as 909cd82 - Minor improvements to the not responding dialog
Attachment 224718 [details] pushed as 09713c5 - delete: Unbreak string freeze
Comment 12 Florian Müllner 2012-09-19 09:23:12 UTC
Created attachment 224719 [details] [review]
Revert "delete: Unbreak string freeze"

This reverts commit 09713c5fd4efd123923b8c77df1a126dced96465.
Comment 13 Jakub Steiner 2012-09-19 09:28:52 UTC
Created attachment 224721 [details]
lighter symbolic

Symbolic might be more approproitae here, but I would not have it so dark.. how about #babdb6?
Comment 14 William Jon McCann 2012-09-19 09:49:41 UTC
The darkness was my main concern. I like this one.
Comment 15 Florian Müllner 2012-09-19 09:53:17 UTC
Me too, but I don't see anything we can do here (lest suggesting a very obscure option to the zenity maintainers) - I think the color is best  fixed in gnome-themes-standard.
Comment 16 Lapo Calamandrei 2012-09-19 10:06:40 UTC
Totally doable by the theme I guess, not sure how I can select that GtkImage in that specific dialog tho, I think it needs a styleclass. Also, I'd like to avoid yet another special case, can this be a general solution somehow?
Comment 17 Florian Müllner 2012-09-19 10:44:03 UTC
(In reply to comment #16)
> Totally doable by the theme I guess, not sure how I can select that GtkImage in
> that specific dialog tho, I think it needs a styleclass.

If it does we have a problem - as window manager we cannot open "proper" windows, which is why we spawn zenity on the command line. A --dialog-icon-style-class option is definitively in crack territory, so I would be rather worried if we get such a patch accepted :-)

(Mmmh, on the other hand, an option for the entire dialog might be acceptable, so you could match something like GtkDialog:mutter-force-quit > GtkImage)


> Also, I'd like to avoid yet another special case, can this be a general solution somehow?

You'll tell me :-)  It would definitively be my preferred option if possible.
Comment 18 Jasper St. Pierre (not reading bugmail) 2012-09-19 10:49:53 UTC
Why not just create a tiny custom program rather than spawning Zenity?
Comment 19 Florian Müllner 2012-09-19 11:35:19 UTC
Running in circles is fun: http://git.gnome.org/browse/metacity/commit?id=0b3f45bb1bf8b73e4b40 :-)
Comment 20 Florian Müllner 2012-09-19 12:35:46 UTC
Created attachment 224746 [details] [review]
util: Guard against older zenity versions

Plenty of ugly here, but it works; revert when the zenity version
we depend on stops being bleeding-edge (or we can assume a zenity
version that does not error out on unknown options).
Comment 21 Colin Walters 2012-09-19 12:49:25 UTC
Review of attachment 224746 [details] [review]:

Ugly, but OK.

If you wanted to optimize a bit, we could at least cache the result.  But I suppose this code will die immediately on 3.7.

::: src/core/util.c
@@ +562,3 @@
+  gboolean rv;
+
+  command = g_strdup_printf ("zenity %s", section);

This is safe because you're only passing string literals here.
Comment 22 Florian Müllner 2012-09-19 13:15:27 UTC
Attachment 224664 [details] pushed as 7e1e932 - utils: Request a modal dialog when transient_for is set
Attachment 224746 [details] pushed as 5eb7274 - util: Guard against older zenity versions

(In reply to comment #21)
> If you wanted to optimize a bit, we could at least cache the result.  But I
> suppose this code will die immediately on 3.7.

That's the idea, yes. I did consider caching, but it seemed a bit overkill - if we really end up displaying those dialogs a lot, something else is badly wrong.
Comment 23 Florian Müllner 2012-10-16 12:48:23 UTC
Attachment 224719 [details] pushed as 07d8b9c - Revert "delete: Unbreak string freeze"