After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682891 - Message badges need restyling
Message badges need restyling
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Debarshi Ray
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-28 18:21 UTC by Allan Day
Modified: 2012-09-10 16:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the current state (27.35 KB, image/png)
2012-08-28 18:21 UTC, Allan Day
  Details
messageTray: Restyle the summary counters (9.43 KB, patch)
2012-09-10 15:41 UTC, Debarshi Ray
committed Details | Review
Screenshot with five pending messages (10.52 KB, image/png)
2012-09-10 15:42 UTC, Debarshi Ray
  Details
Screenshot with lots of pending messages (9.80 KB, image/png)
2012-09-10 15:42 UTC, Debarshi Ray
  Details

Description Allan Day 2012-08-28 18:21:57 UTC
Created attachment 222674 [details]
Screenshot of the current state

The message badges which display a count of missed notifications haven't been updated to match the new message tray. This leaves them looking small and out of place (see attached screenshot).

There are designs for bigger, prettier message badges:

http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/notifications-chat-tray.png

One thing that me and Jasper discussed on IRC was limiting the badge count to double digits. If the count goes over 99 we can just show an ellipsis instead of a number. This will enable us to keep the round badge shape.
Comment 1 Debarshi Ray 2012-09-10 15:41:49 UTC
Created attachment 223924 [details] [review]
messageTray: Restyle the summary counters
Comment 2 Debarshi Ray 2012-09-10 15:42:24 UTC
Created attachment 223925 [details]
Screenshot with five pending messages
Comment 3 Debarshi Ray 2012-09-10 15:42:43 UTC
Created attachment 223926 [details]
Screenshot with lots of pending messages
Comment 4 drago01 2012-09-10 16:10:39 UTC
Review of attachment 223924 [details] [review]:

Looks good.
Comment 5 Debarshi Ray 2012-09-10 16:12:49 UTC
commit 8a269041fb3044d7efec0689ff5bd606feb84ee9
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Mon Sep 10 17:41:30 2012 +0200

    messageTray: Restyle the summary counters
    
    They are bigger and show an ellipsis if the count goes over 99. They
    now have a blurred background and a drop shadow based on
    data/theme/close-window.svg.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=682891