After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681392 - Move the desktop upwards when the message tray is revealed
Move the desktop upwards when the message tray is revealed
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.5.x
Other All
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 681480
Blocks:
 
 
Reported: 2012-08-07 17:13 UTC by Debarshi Ray
Modified: 2012-08-20 01:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a toggle-message-tray keybinding to move the windows up/down (6.24 KB, patch)
2012-08-07 17:22 UTC, Debarshi Ray
needs-work Details | Review
messageTray: Clone, clip & move the window_group instead of each actor (5.76 KB, patch)
2012-08-07 17:23 UTC, Debarshi Ray
reviewed Details | Review
messageTray: Use a Lightbox to shade the rest of the uiGroup (2.10 KB, patch)
2012-08-08 17:52 UTC, Debarshi Ray
none Details | Review
messageTray: Add a toggle-message-tray keybinding to toggle the tray (2.44 KB, patch)
2012-08-08 21:20 UTC, Debarshi Ray
committed Details | Review
messageTray: Clone, clip & move the window_group when tray is toggled (4.55 KB, patch)
2012-08-08 21:20 UTC, Debarshi Ray
reviewed Details | Review
messageTray: Use a Lightbox to shade the rest of the uiGroup (2.18 KB, patch)
2012-08-08 21:21 UTC, Debarshi Ray
none Details | Review
messageTray: Clone, clip & move the window_group when tray is toggled (4.23 KB, patch)
2012-08-08 23:32 UTC, Debarshi Ray
none Details | Review
messageTray: Clone, clip & move the window_group when tray is toggled (4.24 KB, patch)
2012-08-08 23:37 UTC, Debarshi Ray
committed Details | Review
messageTray: Use a Lightbox to shade the rest of the uiGroup (2.19 KB, patch)
2012-08-13 12:12 UTC, Debarshi Ray
none Details | Review
messageTray: Use a Lightbox to shade the window_group (2.18 KB, patch)
2012-08-13 16:00 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2012-08-07 17:13:03 UTC
Design:
https://live.gnome.org/GnomeShell/Design/Guidelines/MessageTray

When the message tray is revealed the windows and the wallpaper should move up as if the tray pushed the desktop upwards. They should be restored when the tray is hidden.
Comment 1 Debarshi Ray 2012-08-07 17:22:53 UTC
Created attachment 220586 [details] [review]
Add a toggle-message-tray keybinding to move the windows up/down
Comment 2 Debarshi Ray 2012-08-07 17:23:41 UTC
Created attachment 220587 [details] [review]
messageTray: Clone, clip & move the window_group instead of each actor
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-08-07 17:24:36 UTC
Review of attachment 220587 [details] [review]:

Instead of each actor?

(Commit message needs updating after squash)
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-08-07 17:25:10 UTC
Review of attachment 220586 [details] [review]:

Oh. This is not what I meant at all.

I meant to just open/close the tray without shifting the windows at all.
Comment 5 Debarshi Ray 2012-08-08 17:52:37 UTC
Created attachment 220710 [details] [review]
messageTray: Use a Lightbox to shade the rest of the uiGroup
Comment 6 Debarshi Ray 2012-08-08 17:53:22 UTC
Sorry, for misunderstanding which way you wanted the patches to be squashed. New ones coming up tomorrow.
Comment 7 Debarshi Ray 2012-08-08 21:20:00 UTC
Created attachment 220737 [details] [review]
messageTray: Add a toggle-message-tray keybinding to toggle the tray
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-08-08 21:20:35 UTC
Review of attachment 220737 [details] [review]:

Yes.
Comment 9 Debarshi Ray 2012-08-08 21:20:41 UTC
Created attachment 220738 [details] [review]
messageTray: Clone, clip & move the window_group when tray is toggled
Comment 10 Debarshi Ray 2012-08-08 21:21:20 UTC
Created attachment 220739 [details] [review]
messageTray: Use a Lightbox to shade the rest of the uiGroup
Comment 11 Jasper St. Pierre (not reading bugmail) 2012-08-08 21:24:55 UTC
Review of attachment 220738 [details] [review]:

::: js/ui/messageTray.js
@@ +2265,3 @@
                     { y: -this.actor.height,
                       time: ANIMATION_TIME,
+                      transition: 'easeOutQuad',

???

@@ +2289,3 @@
+                           transition: 'easeOutQuad',
+                           onUpdate: Lang.bind(this, function() {
+                               let progress = -1 * this._desktopClone.y; // y is -ve

-ve?

@@ +2290,3 @@
+                           onUpdate: Lang.bind(this, function() {
+                               let progress = -1 * this._desktopClone.y; // y is -ve
+                               this._desktopClone.set_clip(geometry.x,

While Tweener doesn't know how to tween a ClutterGeometry, Clutter does. I wonder if we should use a Clutter animation here.

@@ +2302,3 @@
                     { y: 0,
                       time: ANIMATION_TIME,
+                      transition: 'easeOutQuad',

???

@@ +2315,3 @@
+                           onComplete: Lang.bind(this, function() {
+                               this._desktopClone.hide();
+                               Main.uiGroup.remove_actor(this._desktopClone);

Use this._desktopClone.destroy() rather than a hide/remove.
Comment 12 Debarshi Ray 2012-08-08 23:20:06 UTC
(In reply to comment #11)
> Review of attachment 220738 [details] [review]:
> @@ +2289,3 @@
> +                           transition: 'easeOutQuad',
> +                           onUpdate: Lang.bind(this, function() {
> +                               let progress = -1 * this._desktopClone.y; // y
> is -ve
> 
> -ve?

y moves from 0 to -this.actor.height. So it is mostly negative.
Comment 13 Jasper St. Pierre (not reading bugmail) 2012-08-08 23:27:38 UTC
What's the "ve"?
Comment 14 Debarshi Ray 2012-08-08 23:32:24 UTC
Created attachment 220751 [details] [review]
messageTray: Clone, clip & move the window_group when tray is toggled

Initially I chose to make "progress" a positive value because it looked more intuitive to increase clip.y and decrease clip.height while moving up and the reverse when moving down. But I don't really care.
Comment 15 Debarshi Ray 2012-08-08 23:37:10 UTC
Created attachment 220752 [details] [review]
messageTray: Clone, clip & move the window_group when tray is toggled

Replace -ve with negative.
Comment 16 Debarshi Ray 2012-08-13 12:12:35 UTC
Created attachment 221011 [details] [review]
messageTray: Use a Lightbox to shade the rest of the uiGroup

Highlight the Main.layoutManager.trayBox instead of the messageTray.actor because the trayBox is a direct child of the Main.uiGroup.
Comment 17 Debarshi Ray 2012-08-13 16:00:02 UTC
Created attachment 221029 [details] [review]
messageTray: Use a Lightbox to shade the window_group

Shade the window_group and not the uiGroup so that the summary box pointers don't get shaded. This causes the panel to be outside the shade, but since it is part of the chrome, probably that is ok.
Comment 18 Jasper St. Pierre (not reading bugmail) 2012-08-20 01:16:59 UTC
Attachment 220752 [details] pushed as 16bbe97 - messageTray: Clone, clip & move the window_group when tray is toggled
Attachment 221029 [details] pushed as cb50953 - messageTray: Use a Lightbox to shade the window_group