GNOME Bugzilla – Bug 679031
playbin/playsink: Add support for audio and video filters
Last modified: 2014-03-16 17:39:12 UTC
Could be an additional property audio-filter and video-filter that playbin then inserts in front of the actual sink. This is useful for adding things like an equalizer or some video postprocessing elements in front of the sink. Currently applications use a custom sink-bin for this but this has the disadvantage that playbin's internal sink selection mechanism is not used.
See also bug 696045, which asks for an audio filter property that could be bypassed when passthrough is used. The fact that it's bypassed should be advertised to the application, so it doesn't offer the functionality of the filter (in totem's case, it would reset the playback rate to 1x).
Another one related to this: https://bugzilla.gnome.org/show_bug.cgi?id=687182
*** Bug 696045 has been marked as a duplicate of this bug. ***
Created attachment 272016 [details] [review] playsink: Fix documentation for what the audio chain looks like
Created attachment 272017 [details] [review] playback: Add video-/audio-filter properties This provides an audio-filter and video-filter property to allow applications to set filter elements/bins. The idea is that these will be applied if possible -- for non-raw sinks, the filters will be skipped. If the application wishes to force the application of the filters, this can be done by setting the new flag introduced on playsink - GST_PLAY_FLAG_FORCE_FILTERS.
(In reply to comment #5) > Created an attachment (id=272017) [details] [review] > playback: Add video-/audio-filter properties The string equivalent for the GST_PLAY_FLAG_FORCE_FILTERS is missing. I've added that locally, and appended the flag to the copy of the enum in b/tests/examples/playback/playback-test.c. Will update the patch here based on any other comments that come up.
Created attachment 272068 [details] [review] playback: Add video-/audio-filter properties This provides an audio-filter and video-filter property to allow applications to set filter elements/bins. The idea is that these will e applied if possible -- for non-raw sinks, the filters will be skipped. If the application wishes to force the application of the filters, this can be done by setting the new flag introduced on playsink - GST_PLAY_FLAG_FORCE_FILTERS.
commit f4cab18ec13548426245e5cc1ae43caa69a42317 Author: Arun Raghavan <arun@accosted.net> Date: Sun Mar 16 17:00:38 2014 +0100 playback: Add video-/audio-filter properties This provides an audio-filter and video-filter property to allow applications to set filter elements/bins. The idea is that these will e applied if possible -- for non-raw sinks, the filters will be skipped. If the application wishes to force the application of the filters, this can be done by setting the new flag introduced on playsink - GST_PLAY_FLAG_FORCE_FILTERS. https://bugzilla.gnome.org/show_bug.cgi?id=679031