After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676600 - Port to GMenu
Port to GMenu
Status: RESOLVED FIXED
Product: almanah
Classification: Other
Component: General
0.9.x
Other All
: Normal normal
: ---
Assigned To: Álvaro Peña
diary-maint
Depends on:
Blocks: 674957
 
 
Reported: 2012-05-22 22:39 UTC by Philip Withnall
Modified: 2012-11-20 22:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Almanah migration to GMenu (46.64 KB, patch)
2012-11-18 18:04 UTC, Álvaro Peña
accepted-commit_now Details | Review

Description Philip Withnall 2012-05-22 22:39:06 UTC
Almanah needs at least some of its File menu porting to GMenu.

https://live.gnome.org/GnomeGoals/PortToGMenu
Comment 1 Álvaro Peña 2012-05-24 17:52:23 UTC
I think this require a reduction of the current menu bar, I propose:

 * "Encrypt" or "Encryp options"  (just the select the encryption key)
 * (space)
 * Print
 * (space)
 * Export
 * Import
 * (space)
 * Help
Comment 2 Philip Withnall 2012-05-27 21:10:21 UTC
(In reply to comment #1)
> I think this require a reduction of the current menu bar, I propose:
> 
>  * "Encrypt" or "Encryp options"  (just the select the encryption key)
>  * (space)
>  * Print
>  * (space)
>  * Export
>  * Import
>  * (space)
>  * Help

The (sparse) advice here suggests that “Print” should not be in the GMenu:
http://developer.gnome.org/gtk3/3.4/GtkApplication.html#gtk-application-set-app-menu

I’d prefer to see “Preferences” rather than “Encrypt options” (or similar), since there are preferences for spell checking as well, and it’s a more common term.

Apart from that, I have no idea what should go in the GMenu. Personally, I don’t see the appeal in GMenu and think there’s a terrible lack of guidance as to the purpose of having a separate menu bar and GMenu. I guess we need to pester a member of the design team about it.

(I also don’t see the need to reduce the current menu bar: I think it’s already about as minimal as it can be. But then I’m not a designer and you’re the maintainer now, so you can make the final decision. :-) )
Comment 3 Álvaro Peña 2012-09-25 17:42:30 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > I think this require a reduction of the current menu bar, I propose:
> > 
> >  * "Encrypt" or "Encryp options"  (just the select the encryption key)
> >  * (space)
> >  * Print
> >  * (space)
> >  * Export
> >  * Import
> >  * (space)
> >  * Help
> 
> The (sparse) advice here suggests that “Print” should not be in the GMenu:
> http://developer.gnome.org/gtk3/3.4/GtkApplication.html#gtk-application-set-app-menu

In this case, the Print item is an application operation, not just a window based, because Almanah only have one window. I think a Print item in this case is justified.

> I’d prefer to see “Preferences” rather than “Encrypt options” (or similar),
> since there are preferences for spell checking as well, and it’s a more common
> term.

Yes, I have been forgotten the spell checking checkbox, but we can add it in the GMenu too. Considering that only two things (encryption and spell checking) are shown in the preferences dialog I think we can add them as separate items in the GMenu

> Apart from that, I have no idea what should go in the GMenu. Personally, I
> don’t see the appeal in GMenu and think there’s a terrible lack of guidance as
> to the purpose of having a separate menu bar and GMenu. I guess we need to
> pester a member of the design team about it.

I think that it's better to just have a GMenu and remove the window menu bar. Yes, it's a big change, but I hope that this change can improve the usability to a more direct user action.

We can add a menu toolbutton in the toolbar with cut/copy/paste/delete/insert time at the moment, like Epiphany or Nautilus.

> (I also don’t see the need to reduce the current menu bar: I think it’s already
> about as minimal as it can be. But then I’m not a designer and you’re the
> maintainer now, so you can make the final decision. :-) )

Yes, I have been forgotten other items. But a reduction is possible, for example:

File: Page setup, Print preview and Print can be merged in a Print item.
Format: All the menu can be removed :)
Help: can be removed too, just an About in GMenu.

Another propose:

 * Go to today
 * Select day
 * Search
 * (space)
 * "Encrypt" or "Encryp options"  (just the select the encryption key)
 * Enable spell checking
 * (space)
 * Print
 * (space)
 * Export
 * Import
 * (space)
 * About
 * (space)
 * Quit

But I think that "Go to today" and "Select day" must be placed in the date selection window (go to today already) and the "Search" item would be better in the Overview window...
Comment 4 Philip Withnall 2012-09-28 17:14:05 UTC
(In reply to comment #3)
> In this case, the Print item is an application operation, not just a window
> based, because Almanah only have one window. I think a Print item in this case
> is justified.

OK.

> Yes, I have been forgotten the spell checking checkbox, but we can add it in
> the GMenu too. Considering that only two things (encryption and spell checking)
> are shown in the preferences dialog I think we can add them as separate items
> in the GMenu

I personally still think that ‘Preferences’ would be better, since Almanah might grow more preferences in future.

> Another propose:
> 
>  * Go to today
>  * Select day
>  * Search
>  * (space)
>  * "Encrypt" or "Encryp options"  (just the select the encryption key)
>  * Enable spell checking
>  * (space)
>  * Print
>  * (space)
>  * Export
>  * Import
>  * (space)
>  * About
>  * (space)
>  * Quit
> 
> But I think that "Go to today" and "Select day" must be placed in the date
> selection window (go to today already) and the "Search" item would be better in
> the Overview window...

Apart from ‘Preferences’, that looks reasonable to me.
Comment 6 Philip Withnall 2012-09-30 19:37:00 UTC
(In reply to comment #5)
> Illustrated with a mockup:
> https://live.gnome.org/Almanah_Diary/Design?action=AttachFile&do=get&target=almanah_entry_menu.png

Nice!
Comment 7 Álvaro Peña 2012-11-18 18:04:12 UTC
Created attachment 229298 [details] [review]
Almanah migration to GMenu

Attached the patch for comments
Comment 8 Álvaro Peña 2012-11-20 22:04:05 UTC
Review of attachment 229298 [details] [review]:

So no comments, commit now...