After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676330 - no error indication if vpn fails
no error indication if vpn fails
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-18 15:44 UTC by Matthias Clasen
Modified: 2012-06-01 20:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
NetworkMenu: show notifications for failed VPN connections (10.88 KB, patch)
2012-05-18 16:39 UTC, Giovanni Campagna 		committed Details | Review

Description Matthias Clasen 2012-05-18 15:44:32 UTC 
if I enter a wrong passphrase or something else goes wrong with starting a vpn connection, the only error indication I get is that the network icon jumps back to 'wifi'. It would be nicer to have some acutal error indication, imo. Maybe with a 'retry' button.
Comment 1 Giovanni Campagna 2012-05-18 16:39:45 UTC 
Created attachment 214390 [details] [review]
NetworkMenu: show notifications for failed VPN connections

Refactor NMDeviceVPN to be more like the other NMDevices, including
having a valid getSectionTitle() and emitting signals when the
underlying connection changes state.
Use the existing notification infrastructure to hook these signals
to actual notifications (including some code consolidation).
Comment 2 Matthias Clasen 2012-05-18 17:50:39 UTC 
Thats an improvement, thanks !

Small wart: I also get the notification when I hit cancel.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-06-01 11:36:53 UTC 
Review of attachment 214390 [details] [review]:

This looks fine to me.
Comment 4 Giovanni Campagna 2012-06-01 20:40:29 UTC 
Attachment 214390 [details] pushed as 7911154 - NetworkMenu: show notifications for failed VPN connections