GNOME Bugzilla – Bug 674949
Provide an app menu
Last modified: 2012-09-30 20:45:40 UTC
See https://live.gnome.org/GnomeGoals/PortToGMenu Recommended app menu format: Search for Open Files -- Preferences -- Help About System Monitor Quit This requires that you add a View menu button to the Processes tab, alongside a refresh button: +---------+ +---------+ | Refresh | | View v | +---------+ +---------+ Where View contains: ( ) Active Processes (o) All Processes ( ) My Processes --- [ ] Dependencies Everything else can be accessed via context menus (and makes more sense that way).
Is it now considered OK to have stuff only accessible through context menus? http://developer.gnome.org/hig-book/3.4/menus-types.html.en#menu-type-popup "Since the user may not be aware of their presence, do not provide functions that are only accessible from popup menus unless you are confident that your target users will know how to use popup menus."
(In reply to comment #1) > Is it now considered OK to have stuff only accessible through context menus? > > http://developer.gnome.org/hig-book/3.4/menus-types.html.en#menu-type-popup > > "Since the user may not be aware of their presence, do not provide functions > that are only accessible from popup menus unless you are confident that your > target users will know how to use popup menus." The options that will only be in a context menu are context driven and are specific to a single, delineated part of the ui. A context menu is appropriate in that situation and is in some ways less confusing than housing them in a menu bar or app menu (a long list of insensitive menu items ain't good).
I wasn't really questioning whether context menus are good. I think it's obvious they are. But the existing HIG insists that a large number of people don't know about them, so there should be an alternative way to accomplish an action. Maybe that's no longer true; I don't know. But I think we need clarification when designers ask developers to explicitly go against the HIG.
I guess this is blocked on bug 351087, aka porting to GtkApplication.
Created attachment 224788 [details] [review] Port to Application menu The menubar is removed and the application-wide actions are made available in the Application menu. Actions in the "view" menu related to the "Processes" tab are accomodated in a menu button inside the tab itself. --- Depends on the patch at bug 351087
Review of attachment 224788 [details] [review]: Please also update the configure.ac to require the gtk+ version introducing gtkmenubutton.
Created attachment 224851 [details] [review] Port to Application menu The menubar is removed and the application-wide actions are made available in the Application menu. Actions in the "view" menu related to the "Processes" tab are accomodated in a menu button inside the tab itself.
Review of attachment 224851 [details] [review]: The patch references menus.ui from the makefile and the sources, however the file itself is not included in the patch, please add it.
Created attachment 224984 [details] [review] Port to Application menu The menubar is removed and the application-wide actions are made available in the Application menu. Actions in the "view" menu related to the "Processes" tab are accomodated in a menu button inside the tab itself. Opss, sorry :) not it should be there
Review of attachment 224984 [details] [review]: Thanks for the quick responses. This one looks better, checked it, and does what it should, appmenu works, refresh and view menu integrated in processes tab works. However the menus.ui isn't marked for translation in the po/POTFILES.in. Please mark it as translatable with the proper type, and I think if that's done, it'll be OK, I will not have anything else against the patch.
Created attachment 225019 [details] [review] Port to Application menu The menubar is removed and the application-wide actions are made available in the Application menu. Actions in the "view" menu related to the "Processes" tab are accomodated in a menu button inside the tab itself.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.