GNOME Bugzilla – Bug 674939
Provide an app menu
Last modified: 2012-09-14 20:57:23 UTC
See https://live.gnome.org/GnomeGoals/PortToGMenu Recommended app menu format: New Window --- Print... Save As... --- ✓ Sidebar ✓ Statusbar --- Preferences --- Help About Dictionary Quit You can probably nuke the rest of the menu bar.
Created attachment 213702 [details] [review] window: Make sure to set the application on new windows
Created attachment 213703 [details] [review] window: Base on GtkApplicationWindow rather than GtkWindow
Created attachment 213704 [details] [review] window: Port to GMenu Menus using GtkUIManager/GtkAction should be phased out now in favor of GMenu. Port to the new API, but don't change any UI just yet ...
Created attachment 213705 [details] [review] app: Add a minimal application menu While Dictionary is a rather small application which probably could do well with only an application menu and no menubar, this would require a couple of design changes, as almost all actions currently in the menus are window-specific. So for now, leave the menubar alone and only add a minimal application menu.
Review of attachment 213702 [details] [review]: looks good
Review of attachment 213703 [details] [review]: looks good
Review of attachment 213704 [details] [review]: looks good
Review of attachment 213705 [details] [review]: looks good. as far as a redesign is concerned, I think we ought to get rid of basically every menu item and have just toolbar items for *some* of the actions.
(In reply to comment #8) > as far as a redesign is concerned, I think we ought to get rid of basically > every menu item and have just toolbar items for *some* of the actions. Oh, I agree. How about making the "show sidebar"/"show statusbar" global (so they can go in the app menu) and provide toolbar items for "Print"/"Save As"?
Attachment 213702 [details] pushed as 5fb9b15 - window: Make sure to set the application on new windows Attachment 213703 [details] pushed as 9006f1a - window: Base on GtkApplicationWindow rather than GtkWindow Attachment 213704 [details] pushed as 64cf0ba - window: Port to GMenu Attachment 213705 [details] pushed as 0e9e1cb - app: Add a minimal application menu
(In reply to comment #9) > (In reply to comment #8) > > as far as a redesign is concerned, I think we ought to get rid of basically > > every menu item and have just toolbar items for *some* of the actions. > > Oh, I agree. How about making the "show sidebar"/"show statusbar" global (so > they can go in the app menu) actually, I'd remove the statusbar option altogether; the side bar could be a button, similar to how Totem does it, or a toggle in the Preferences; right now, it's in the menu for the accelerator. personally, even the sidebar feels like overkill: we use it mostly to show multiple matching words, but that could be done inline within the text area, like: 'See also: foo, bar, baz, blah, quux' in case of multiple matches, and with something like: 'No matches for "blah" found, but these words may be related: foo, bar, baz, quux' > and provide toolbar items for "Print"/"Save As"? these are definitely what I had in mind. "Save as" could even go away - saving to text/plain is pretty pointless, when you can print to a PDF.