After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674643 - Completion: some translatable strings not in the PO files
Completion: some translatable strings not in the PO files
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-23 17:06 UTC by Sébastien Wilmet
Modified: 2012-05-14 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Completion: use GResource for the XML UI description (20.09 KB, patch)
2012-04-23 22:31 UTC, Sébastien Wilmet
none Details | Review
Completion: migrate the UI description to GtkGrid (7.72 KB, patch)
2012-04-24 13:59 UTC, Sébastien Wilmet
none Details | Review
Completion: use GResource for the XML UI description (20.09 KB, patch)
2012-05-06 14:28 UTC, Sébastien Wilmet
none Details | Review
Completion: fix mnemonic of the "Details" button (1.29 KB, patch)
2012-05-06 14:30 UTC, Sébastien Wilmet
none Details | Review

Description Sébastien Wilmet 2012-04-23 17:06:24 UTC
The gtksourcecompletionui.h file contains the XML UI description of the completion window, which contains two translatable sentences.

The problem is that these strings are not extracted into the PO files.

One simple solution would be to set the strings in the code, instead of placing them in the XML.

Another (better) solution is to place the XML UI description in a *.ui or *.xml file, use GResource to load it, and add it in POTFILES.in so the sentences are extracted.
Comment 1 Sébastien Wilmet 2012-04-23 22:31:51 UTC
Created attachment 212637 [details] [review]
Completion: use GResource for the XML UI description

There were two translatable strings in the UI description that were not
extracted into the PO files.

GTK+ 3.4 is required, as well as GIO 2.32.
Comment 2 Ignacio Casal Quinteiro (nacho) 2012-04-24 06:31:39 UTC
Patch, looks good to me. Although see that first we need to branch for gnome-3-4 before applying it.
Comment 3 Sébastien Wilmet 2012-04-24 13:58:14 UTC
OK, I'll wait that you or another maintainer create the branch, then.

I have another commit for the UI description, which doesn't fix this bug, but since it's related to the same subject, I'll attach it here.
Comment 4 Sébastien Wilmet 2012-04-24 13:59:35 UTC
Created attachment 212707 [details] [review]
Completion: migrate the UI description to GtkGrid

The scrollbar policy is by default "automatic" in GTK+ 3.

The first children of the GtkGrid's don't have packing properties
because all the default values are OK for them.
Comment 5 Sébastien Wilmet 2012-05-06 14:28:23 UTC
Created attachment 213549 [details] [review]
Completion: use GResource for the XML UI description

Update the commit to avoid conflict with the master branch.
Comment 6 Sébastien Wilmet 2012-05-06 14:30:17 UTC
Created attachment 213550 [details] [review]
Completion: fix mnemonic of the "Details" button

Another small patch related to the UI description.

Commit message:

Due to bug #674759 [1], the mnemonic for the "Details" button didn't
work when the "gtk-auto-mnemonics" setting is true.

But anyway we don't need markup for this label, so it's better to remove
it.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=674759
Comment 7 Paolo Borelli 2012-05-14 15:58:16 UTC
I think these should all be committed to master even before branching: since the strings are already present in the ui untranslated, it is not a string freeze break
Comment 8 Sébastien Wilmet 2012-05-14 16:51:33 UTC
Pushed, thanks.