GNOME Bugzilla – Bug 674643
Completion: some translatable strings not in the PO files
Last modified: 2012-05-14 16:51:33 UTC
The gtksourcecompletionui.h file contains the XML UI description of the completion window, which contains two translatable sentences. The problem is that these strings are not extracted into the PO files. One simple solution would be to set the strings in the code, instead of placing them in the XML. Another (better) solution is to place the XML UI description in a *.ui or *.xml file, use GResource to load it, and add it in POTFILES.in so the sentences are extracted.
Created attachment 212637 [details] [review] Completion: use GResource for the XML UI description There were two translatable strings in the UI description that were not extracted into the PO files. GTK+ 3.4 is required, as well as GIO 2.32.
Patch, looks good to me. Although see that first we need to branch for gnome-3-4 before applying it.
OK, I'll wait that you or another maintainer create the branch, then. I have another commit for the UI description, which doesn't fix this bug, but since it's related to the same subject, I'll attach it here.
Created attachment 212707 [details] [review] Completion: migrate the UI description to GtkGrid The scrollbar policy is by default "automatic" in GTK+ 3. The first children of the GtkGrid's don't have packing properties because all the default values are OK for them.
Created attachment 213549 [details] [review] Completion: use GResource for the XML UI description Update the commit to avoid conflict with the master branch.
Created attachment 213550 [details] [review] Completion: fix mnemonic of the "Details" button Another small patch related to the UI description. Commit message: Due to bug #674759 [1], the mnemonic for the "Details" button didn't work when the "gtk-auto-mnemonics" setting is true. But anyway we don't need markup for this label, so it's better to remove it. [1] https://bugzilla.gnome.org/show_bug.cgi?id=674759
I think these should all be committed to master even before branching: since the strings are already present in the ui untranslated, it is not a string freeze break
Pushed, thanks.