After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673111 - banshee keeps displaying "Disconnecting media player..."
banshee keeps displaying "Disconnecting media player..."
Status: RESOLVED WONTFIX
Product: banshee
Classification: Other
Component: User Interface
2.4.x
Other Linux
: Normal normal
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2012-03-29 20:06 UTC by Fabrice Bellet
Modified: 2020-03-17 09:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Hide status after disconnecting device (788 bytes, patch)
2012-03-29 20:07 UTC, Fabrice Bellet
reviewed Details | Review

Description Fabrice Bellet 2012-03-29 20:06:55 UTC
Still playing with my SD card having all my Music from my rockbox device,
and using the SD card reader from my X series thinkpad, with the mmc kernel driver...

Clicking on the "Disconnect" button causes just an umount of the related filesystem, the device remains visible on the left pane (bgo #673109). Moreover, the message "Disconnecting media player..." also remains displayed forever on the right part of the interface.

Proposed patch follows.
Comment 1 Fabrice Bellet 2012-03-29 20:07:58 UTC
Created attachment 210899 [details] [review]
Hide status after disconnecting device
Comment 2 Fabrice Bellet 2012-03-29 20:13:20 UTC
This behaviour is hidden when the device is properly removed from the left pane following the Disconnect action (bgo #673109).
Comment 3 Bertrand Lorentz 2012-05-19 16:57:53 UTC
Review of attachment 210899 [details] [review]:

Sorry for taking so long to review your patches.

Wouldn't that patch hide the status message immediately, even if the disconnect operation is not finished ?
And is that patch still necessary if bug #673109 is fixed ? The device would be removed from the left pane, and the right would be gone, right ?
Comment 4 Fabrice Bellet 2012-06-13 15:08:24 UTC
(In reply to comment #3)
> Review of attachment 210899 [details] [review]:
> 
> Sorry for taking so long to review your patches.
> 
> Wouldn't that patch hide the status message immediately, even if the disconnect
> operation is not finished ?

This is not what I observed, but you're right : this is not the right place to hide the status message.

> And is that patch still necessary if bug #673109 is fixed ? The device would be
> removed from the left pane, and the right would be gone, right ?

And this is exact too that this patch is not needed if bug #673109 is fixed. Thanks for your review.
Comment 5 André Klapper 2020-03-17 09:26:11 UTC
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the
responsibility for active development again.
See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.