After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672585 - 2 memory leaks found in error-handling paths in pygoocanvas-0.14.1-6.fc17 using gcc-with-cpychecker static analyzer
2 memory leaks found in error-handling paths in pygoocanvas-0.14.1-6.fc17 usi...
Status: RESOLVED WONTFIX
Product: pygoocanvas
Classification: Deprecated
Component: general
0.14.x
Other Linux
: Normal normal
: ---
Assigned To: Gian Mario Tagliaretti
Gian Mario Tagliaretti
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2012-03-21 19:23 UTC by Dave Malcolm
Modified: 2014-08-02 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dave Malcolm 2012-03-21 19:23:35 UTC
[I originally filed this downstream in Fedora's bug tracker here:
 https://bugzilla.redhat.com/show_bug.cgi?id=800113 ]

Description of problem:
I've been writing an experimental static analysis tool to detect bugs commonly
occurring within C Python extension modules:
  https://fedorahosted.org/gcc-python-plugin/
  http://gcc-python-plugin.readthedocs.org/en/latest/cpychecker.html
  http://fedoraproject.org/wiki/Features/StaticAnalysisOfPythonRefcounts

I ran the latest version of the tool (in git master; post 0.9) on
pygoocanvas-0.14.1-6.fc17.src.rpm, and it reports various errors.

You can see a list of errors here, triaged into categories (from most
significant to least significant):
http://fedorapeople.org/~dmalcolm/gcc-python-plugin/2012-03-05/pygoocanvas-0.14.1-6.fc17/

I've manually reviewed the issues reported by the tool.

Within the category "Reference leaks" the 2 issues reported appear to be
genuine  memory leaks in error-handling paths: the error-handling clauses need
a Py_DECREF(tuple)

Within the category "Segfaults within error-handling paths" the 3 issues
reported appear to be genuine crashers where an allocation fails and returns
NULL; however, given that GLib aborts the process when an allocation fails,
this may be already be a lost cause.

Within the category "Possible reference leaks" the first 2 of the 3 issues
reported appear to be false positives, which I've filed as
https://fedorahosted.org/gcc-python-plugin/ticket/36 ; the third issue is
inconsequential.

Within the category "Returning (PyObject*)NULL without setting an exception"
the 11 issues reported appear to be false positives.
There may of course be other bugs in my checker tool.

Hope this is helpful; let me know if you need help reading the logs that the
tool generates - I know that it could use some improvement.

Version-Release number of selected component (if applicable):
pygoocanvas-0.14.1-6.fc17
gcc-python-plugin post-0.9 git 11462291a66c8db693c8884cb84b795bb5988ffb running
the checker in an *f16* chroot
Comment 1 André Klapper 2014-08-02 12:24:18 UTC
The last Pygoocanvas code changes took place in 2010:
https://git.gnome.org/browse/archive/pygoocanvas/log/

This project is not under active development anymore.

This project has been recently archived in GNOME Git.

It is currently unlikely that there will be any further active development.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this bug report in the future if anyone takes the responsibility for active development again.