GNOME Bugzilla – Bug 672028
gnome-color-manager should not assume that dispcal is /usr/bin/dispcal
Last modified: 2012-03-23 09:11:31 UTC
In some distros (e.g. Gentoo), argyllcms's dispcal is installed as /usr/bin/argyll-dispcal. Instead of hardcoding "/usr/bin/dispcal", gcm_calibrate_argyll_get_tool_filename() should be used to detect the filename.
Created attachment 209671 [details] [review] proposed patch
I've slightly modified how you did your patch: commit 0286297628da8b1ddd6f957f66646250c40a1862 Author: Richard Hughes <richard@hughsie.com> Date: Wed Mar 14 08:50:49 2012 +0000 Provide a way for a program to find out if calibration is enabled Also, do this without exposing internal parts of GcmCalibrateArgyll to the clients. Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=672028 :100644 100644 d54b176... 23f8314... M src/gcm-calibrate-argyll.c :100644 100644 901a428... ce71392... M src/gcm-calibrate-main.c :100644 100644 75f3a14... 60c1c9f... M src/gcm-calibrate.c :100644 100644 ae6842e... 98554fc... M src/gcm-calibrate.h commit cc8b0f4df60c05208ab6778c2a01a8aec6335b41 Author: Alexandre Rostovtsev <tetromino@gentoo.org> Date: Wed Mar 14 08:49:45 2012 +0000 Don't assume dispcal is /usr/bin/dispcal Signed-off-by: Richard Hughes <richard@hughsie.com> :100644 100644 b3c7fce... d54b176... M src/gcm-calibrate-argyll.c Can you try with git master now please? Thanks.