After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672028 - gnome-color-manager should not assume that dispcal is /usr/bin/dispcal
gnome-color-manager should not assume that dispcal is /usr/bin/dispcal
Status: RESOLVED FIXED
Product: gnome-color-manager
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-color-manager-maint
gnome-color-manager-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-14 03:43 UTC by Alexandre Rostovtsev
Modified: 2012-03-23 09:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (3.15 KB, patch)
2012-03-14 03:43 UTC, Alexandre Rostovtsev
none Details | Review

Description Alexandre Rostovtsev 2012-03-14 03:43:00 UTC
In some distros (e.g. Gentoo), argyllcms's dispcal is installed as /usr/bin/argyll-dispcal. Instead of hardcoding "/usr/bin/dispcal", gcm_calibrate_argyll_get_tool_filename() should be used to detect the filename.
Comment 1 Alexandre Rostovtsev 2012-03-14 03:43:50 UTC
Created attachment 209671 [details] [review]
proposed patch
Comment 2 Richard Hughes 2012-03-14 08:54:32 UTC
I've slightly modified how you did your patch:

commit 0286297628da8b1ddd6f957f66646250c40a1862
Author: Richard Hughes <richard@hughsie.com>
Date:   Wed Mar 14 08:50:49 2012 +0000

    Provide a way for a program to find out if calibration is enabled
    
    Also, do this without exposing internal parts of GcmCalibrateArgyll to the clients.
    
    Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=672028

:100644 100644 d54b176... 23f8314... M  src/gcm-calibrate-argyll.c
:100644 100644 901a428... ce71392... M  src/gcm-calibrate-main.c
:100644 100644 75f3a14... 60c1c9f... M  src/gcm-calibrate.c
:100644 100644 ae6842e... 98554fc... M  src/gcm-calibrate.h

commit cc8b0f4df60c05208ab6778c2a01a8aec6335b41
Author: Alexandre Rostovtsev <tetromino@gentoo.org>
Date:   Wed Mar 14 08:49:45 2012 +0000

    Don't assume dispcal is /usr/bin/dispcal
    
    Signed-off-by: Richard Hughes <richard@hughsie.com>

:100644 100644 b3c7fce... d54b176... M  src/gcm-calibrate-argyll.c

Can you try with git master now please? Thanks.