After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671329 - Panel separator should reflect theme
Panel separator should reflect theme
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-05 01:43 UTC by Peter Hurley
Modified: 2012-03-05 08:06 UTC
See Also:
GNOME target: ---
GNOME version: 3.1/3.2

Attachments
[Patch 1/5] Use GtkSeparator to draw PanelSeparator (4.53 KB, patch)
2012-03-05 01:45 UTC, Peter Hurley 		committed Details | Review
[Patch 2/5] Remove unnecessary local variable (1.25 KB, patch)
2012-03-05 01:46 UTC, Peter Hurley 		committed Details | Review
[Patch 3/5] Size the PanelSeparator by css styling (5.03 KB, patch)
2012-03-05 01:47 UTC, Peter Hurley 		committed Details | Review
[Patch 4/5] Add style class for orientation to PanelSeparator (2.47 KB, patch)
2012-03-05 01:48 UTC, Peter Hurley 		committed Details | Review
[Patch 5/5] Resize PanelSeparator on orientation change (2.98 KB, patch)
2012-03-05 01:50 UTC, Peter Hurley 		committed Details | Review

Description Peter Hurley 2012-03-05 01:43:26 UTC 
The panel separator should respect and reflect themeing choices.

1) The separator itself should be rendered as a GtkSeparator so the theme can render it like other separators.
2) The size should be controlled by the theme - border + padding + size of GtkSeparator.
3) The style class should reflect the current orientation so the separator can be themed differently depending on orientation.
Comment 1 Peter Hurley 2012-03-05 01:45:51 UTC 
Created attachment 208970 [details] [review]
[Patch 1/5] Use GtkSeparator to draw PanelSeparator

Attached is a patch series to implement this behavior.
Comment 2 Peter Hurley 2012-03-05 01:46:29 UTC 
Created attachment 208971 [details] [review]
[Patch 2/5] Remove unnecessary local variable
Comment 3 Peter Hurley 2012-03-05 01:47:17 UTC 
Created attachment 208972 [details] [review]
[Patch 3/5] Size the PanelSeparator by css styling
Comment 4 Peter Hurley 2012-03-05 01:48:06 UTC 
Created attachment 208973 [details] [review]
[Patch 4/5] Add style class for orientation to PanelSeparator
Comment 5 Peter Hurley 2012-03-05 01:50:40 UTC 
Created attachment 208975 [details] [review]
[Patch 5/5] Resize PanelSeparator on orientation change
Comment 6 Vincent Untz 2012-03-05 08:06:21 UTC 
Thanks, I've fixed the coding style and pushed everything.