After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669682 - Trivial build fixes
Trivial build fixes
Status: RESOLVED OBSOLETE
Product: yelp
Classification: Applications
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-08 15:08 UTC by Patrick Welche
Modified: 2015-01-28 12:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Trivial Makefile.am build fixes (1.28 KB, patch)
2012-02-08 15:08 UTC, Patrick Welche
none Details | Review

Description Patrick Welche 2012-02-08 15:08:47 UTC
Created attachment 207114 [details] [review]
Trivial Makefile.am build fixes

automake tells me:

src/Makefile.am:3: compiling `yelp-application.c' with per-target flags requires `AM_PROG_CC_C_O' in `configure.ac'
tests/Makefile.am:32: variable `test_location_entry_LDADD' is defined but no program or
tests/Makefile.am:32: library has `test_location_entry' as canonical name (possible typo)

which basically implies:

    - src/Makefile.am sets yelp_CFLAGS and yelp_LDFLAGS which are
      "per-target" flags so we need s/AC_PROG_CC_C_O/AM_PROG_CC_C_O/
    - Complete commenting-out of test-location-entry started in
      "Build fixes" 6d4b073c
Comment 1 Patrick Welche 2013-05-20 00:23:19 UTC
ping?
Comment 2 Patrick Welche 2013-07-02 10:02:12 UTC
Starting from automake 1.14:

>   - The AM_PROG_CC_C_O macro can still be called, albeit that should no
>     longer be necessary. This macro is now just a thin wrapper around the
>     Automake-enhanced AC_PROG_CC.  This means, among the other things,
>     that its behaviour is changed in three ways:

The rest of the the patch is still applicable. (Might as well apply the entire patch, as chances are not everyone is already using automake 1.14)
Comment 3 David King 2015-01-28 12:21:29 UTC
This seems obsolete now, as Automake 1.14 has been out for a while (and the test in the patch no longer exists).