After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665997 - Not xesam:userRating in MPRIS metadata
Not xesam:userRating in MPRIS metadata
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Other Extensions
2.2.1
Other Linux
: Normal normal
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-12 13:20 UTC by Lionel Dricot
Modified: 2012-01-08 15:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpris user rating (665 bytes, patch)
2011-12-22 22:43 UTC, olivier dufour 		committed Details | Review

Description Lionel Dricot 2011-12-12 13:20:03 UTC 
With the MPRIS plugin enabled, Banshee 2.2.1 doesn't return the xesam:userRating in the metadata properties of Player interface.

By comparison, Rhythmbox is returning it as a float between 0 and 10 (3 stars being 6.0000)
Comment 1 olivier dufour 2011-12-22 22:43:57 UTC 
Created attachment 204117 [details] [review]
mpris user rating

I found nothing about this on official spec:
http://www.mpris.org/2.1/spec/
But I found this on the wiki of xmms2...

http://xmms2.org/wiki/MPRIS_Metadata
Anyway, I do not know if it is officially part of the spec but here is the small patch to add it...

For the scale nothing seems official so we can choose our scale, I guess.
Comment 2 Lionel Dricot 2011-12-22 22:51:45 UTC 
The scale should be between 0 and 1. As Banshee as 5 stars, it means 0.2 for each (that's also how Rhythmbox handles it).
Comment 3 Bertrand Lorentz 2012-01-08 15:08:37 UTC 
Comment on attachment 204117 [details] [review]
mpris user rating

Thanks for the patch Olivier !

I committed a modified version: adjusting the scale to be 0.0...1.0, and casting the value to double (dbus-sharp doesn't like floats).

Please remember to make patches with "git format-patch", it makes it easier and faster to apply.
Comment 4 Bertrand Lorentz 2012-01-08 15:08:51 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.