After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665803 - Various express installation fixes/improvements
Various express installation fixes/improvements
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-12-08 16:08 UTC by Zeeshan Ali
Modified: 2016-03-31 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add user to admin group (663 bytes, patch)
2011-12-08 16:08 UTC, Zeeshan Ali
reviewed Details | Review
Add button to add password (1.53 KB, patch)
2011-12-08 16:08 UTC, Zeeshan Ali
committed Details | Review
Make use of Object.bind_property() (1.63 KB, patch)
2011-12-08 16:08 UTC, Zeeshan Ali
committed Details | Review
Set timezone in case of express installation (6.29 KB, patch)
2011-12-08 16:08 UTC, Zeeshan Ali
committed Details | Review
Set keyboard layout in case of during express install (2.46 KB, patch)
2011-12-08 16:08 UTC, Zeeshan Ali
committed Details | Review
Set language in case of express installation (3.94 KB, patch)
2011-12-08 16:08 UTC, Zeeshan Ali
reviewed Details | Review
Set admin password in case of express installation (3.27 KB, patch)
2011-12-08 16:08 UTC, Zeeshan Ali
committed Details | Review
Add user account in case of win7/2k8 express install (2.26 KB, patch)
2011-12-08 16:08 UTC, Zeeshan Ali
committed Details | Review
Correctly name win2k8 unattended file (538 bytes, patch)
2011-12-08 16:08 UTC, Zeeshan Ali
none Details | Review
Correctly name win2k8 unattended file (957 bytes, patch)
2011-12-08 16:39 UTC, Zeeshan Ali
committed Details | Review
Set language in case of express installation (4.00 KB, patch)
2011-12-08 17:06 UTC, Zeeshan Ali
committed Details | Review
Add user to admin group for Fedora expres install (689 bytes, patch)
2011-12-08 17:06 UTC, Zeeshan Ali
committed Details | Review

Description Zeeshan Ali 2011-12-08 16:08:10 UTC
Attaching patches with various express installation fixes/improvements.
Comment 1 Zeeshan Ali 2011-12-08 16:08:13 UTC
Created attachment 203074 [details] [review]
Add user to admin group
Comment 2 Zeeshan Ali 2011-12-08 16:08:17 UTC
Created attachment 203075 [details] [review]
Add button to add password

According to the UI design, we should have a button that user clicks to
add password. This patch adds such a button.
Comment 3 Zeeshan Ali 2011-12-08 16:08:22 UTC
Created attachment 203076 [details] [review]
Make use of Object.bind_property()
Comment 4 Zeeshan Ali 2011-12-08 16:08:27 UTC
Created attachment 203077 [details] [review]
Set timezone in case of express installation

This currently only works for Fedora.

* Anaconds seems to expect full name of the timezone rather than
  abbreviation but it seems to accept and use abbreviations too.
* Doing this for windows is another story: Windows XP/2k/2k3 would want
  some custom integer ID(1) and Windows 7/2k8 would want some long
  string name(2).

1. http://blog.williambritt.com/index.php?/archives/23-XP-Unattend-Timezone-Settings.html
2. http://technet.microsoft.com/en-us/library/cc749073%28WS.10%29.aspx
Comment 5 Zeeshan Ali 2011-12-08 16:08:30 UTC
Created attachment 203078 [details] [review]
Set keyboard layout in case of during express install

This currently only works for Fedora.
Comment 6 Zeeshan Ali 2011-12-08 16:08:34 UTC
Created attachment 203079 [details] [review]
Set language in case of express installation

Currently it only works for Windows 7, Windows 2008 and Fedora.
Comment 7 Zeeshan Ali 2011-12-08 16:08:37 UTC
Created attachment 203080 [details] [review]
Set admin password in case of express installation

Use the same password as for the user.
Comment 8 Zeeshan Ali 2011-12-08 16:08:40 UTC
Created attachment 203081 [details] [review]
Add user account in case of win7/2k8 express install
Comment 9 Zeeshan Ali 2011-12-08 16:08:44 UTC
Created attachment 203082 [details] [review]
Correctly name win2k8 unattended file
Comment 10 Marc-Andre Lureau 2011-12-08 16:29:13 UTC
Review of attachment 203076 [details] [review]:

ack
Comment 11 Marc-Andre Lureau 2011-12-08 16:29:16 UTC
Review of attachment 203076 [details] [review]:

ack
Comment 12 Marc-Andre Lureau 2011-12-08 16:29:48 UTC
Review of attachment 203075 [details] [review]:

ack
Comment 13 Marc-Andre Lureau 2011-12-08 16:31:40 UTC
Review of attachment 203074 [details] [review]:

can you rename it to fedora-kickstart.cfg, and put a prefix such as "fedora: add user..."
Comment 14 Marc-Andre Lureau 2011-12-08 16:32:42 UTC
Review of attachment 203077 [details] [review]:

ack
Comment 15 Marc-Andre Lureau 2011-12-08 16:33:01 UTC
Review of attachment 203078 [details] [review]:

ack
Comment 16 Zeeshan Ali 2011-12-08 16:39:29 UTC
Created attachment 203084 [details] [review]
Correctly name win2k8 unattended file
Comment 17 Marc-Andre Lureau 2011-12-08 16:39:37 UTC
Review of attachment 203079 [details] [review]:

::: src/win7-installer.vala
@@ +8,3 @@
+
+        lang = lang.replace ("_", "-");
+        lang = lang.replace (".utf8", "");

Check "locale -a" for all the various possibilities for locale, perhaps you can drop everything after first '.'
Comment 18 Marc-Andre Lureau 2011-12-08 16:40:08 UTC
Review of attachment 203080 [details] [review]:

ack
Comment 19 Marc-Andre Lureau 2011-12-08 16:40:31 UTC
Review of attachment 203081 [details] [review]:

ack
Comment 20 Zeeshan Ali 2011-12-08 17:06:25 UTC
Created attachment 203088 [details] [review]
Set language in case of express installation

Currently it only works for Windows 7, Windows 2008 and Fedora.
Comment 21 Zeeshan Ali 2011-12-08 17:06:56 UTC
Created attachment 203089 [details] [review]
Add user to admin group for Fedora expres install
Comment 22 Zeeshan Ali 2011-12-08 17:22:12 UTC
Attachment 203075 [details] pushed as d5c3d0a - Add button to add password
Attachment 203076 [details] pushed as 5b232c8 - Make use of Object.bind_property()
Attachment 203077 [details] pushed as 7d6c67c - Set timezone in case of express installation
Attachment 203078 [details] pushed as 51c669b - Set keyboard layout in case of during express install
Attachment 203080 [details] pushed as 98ec606 - Set admin password in case of express installation
Attachment 203081 [details] pushed as 195c33b - Add user account in case of win7/2k8 express install
Attachment 203084 [details] pushed as 6fd764d - Correctly name win2k8 unattended file
Attachment 203088 [details] pushed as 469b875 - Set language in case of express installation