GNOME Bugzilla – Bug 665136
Redesigning the about: pages
Last modified: 2011-12-01 08:32:46 UTC
I've made a patch that changes the design of the about:pages.All pages have the same design with about:applications.The pages are: about:memory about:plugins about:epiphany
Created attachment 202378 [details] [review] patch for changing the design of about: pages
Review of attachment 202378 [details] [review]: It looks pretty cool! ::: data/pages/about.css @@ +1,3 @@ +/* Global CSS for pages */ + +h1 { one whitespace error here. @@ +62,3 @@ #ephytext { margin-top: 15%; + font-size: 1.2em; I'm not sure, but I think this is here for nostalgia. Maybe this could be left as it was originally,including the colors? (Xan?)
Review of attachment 202378 [details] [review]: Awesome! ::: data/pages/about.css @@ +28,3 @@ #plugin-table { + margin: 8px; For some reason the margin looks weird to me now. Perhaps the table should be aligned with the text? @@ +62,3 @@ #ephytext { margin-top: 15%; + font-size: 1.2em; Yeah, it was copied as-is from the gecko days becuase of nostalgia. Probably should keep it like that, but I must admit the new one looks better.
(In reply to comment #3) > For some reason the margin looks weird to me now. Perhaps the table should be > aligned with the text? You're right.At first i had the table aligned to the text but i didn't change it for the latest patch. But changing the margin to margin-top: 10px; the page looks much better now. I'll post another patch with the above fix and with the old code of about:epiphany page.
Created attachment 202400 [details] [review] corrected table align and old about:epiphany page fix
Review of attachment 202400 [details] [review]: Seems you forgot to merge your new change in the old patch?
Created attachment 202478 [details] [review] merged the patches Oh my bad.. Here's the new patch.
Review of attachment 202478 [details] [review]: ::: data/pages/about.css @@ +71,1 @@ text-align: right; This still touches a bit about:epiphany :) If you don't have commit rights I'll commit this without these bits, otherwise please change them before committing.
No i don't have commit rights,so it's up to you now.
I've pushed this to master, commit 9a6c740d24b1d4a7deb846d0a1548c5419e0080e Thanks for the patch!