After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665136 - Redesigning the about: pages
Redesigning the about: pages
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-29 15:12 UTC by Tom Tryfonidis
Modified: 2011-12-01 08:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for changing the design of about: pages (4.99 KB, patch)
2011-11-29 15:16 UTC, Tom Tryfonidis
reviewed Details | Review
corrected table align and old about:epiphany page fix (1.48 KB, patch)
2011-11-29 20:46 UTC, Tom Tryfonidis
reviewed Details | Review
merged the patches (4.52 KB, patch)
2011-11-30 19:33 UTC, Tom Tryfonidis
committed Details | Review

Description Tom Tryfonidis 2011-11-29 15:12:58 UTC
I've made a patch that changes the design of the about:pages.All pages have the same design with about:applications.The pages are: 

about:memory
about:plugins 
about:epiphany
Comment 1 Tom Tryfonidis 2011-11-29 15:16:45 UTC
Created attachment 202378 [details] [review]
patch for changing the design of about: pages
Comment 2 Claudio Saavedra 2011-11-29 16:12:52 UTC
Review of attachment 202378 [details] [review]:

It looks pretty cool!

::: data/pages/about.css
@@ +1,3 @@
+/* Global CSS for pages */
+
+h1 { 

one whitespace error here.

@@ +62,3 @@
 #ephytext {
   margin-top: 15%;
+  font-size: 1.2em;

I'm not sure, but I think this is here for nostalgia. Maybe this could be left as it was originally,including the colors? (Xan?)
Comment 3 Xan Lopez 2011-11-29 18:28:00 UTC
Review of attachment 202378 [details] [review]:

Awesome!

::: data/pages/about.css
@@ +28,3 @@
 #plugin-table
 {
+    margin: 8px;

For some reason the margin looks weird to me now. Perhaps the table should be aligned with the text?

@@ +62,3 @@
 #ephytext {
   margin-top: 15%;
+  font-size: 1.2em;

Yeah, it was copied as-is from the gecko days becuase of nostalgia. Probably should keep it like that, but I must admit the new one looks better.
Comment 4 Tom Tryfonidis 2011-11-29 19:30:22 UTC
(In reply to comment #3)
> For some reason the margin looks weird to me now. Perhaps the table should be
> aligned with the text?

You're right.At first i had the table aligned to the text but i didn't change it for the latest patch.
But changing the margin to margin-top: 10px; the page looks much better now.

I'll post another patch with the above fix and with the old code of about:epiphany page.
Comment 5 Tom Tryfonidis 2011-11-29 20:46:52 UTC
Created attachment 202400 [details] [review]
corrected table align and old about:epiphany page fix
Comment 6 Xan Lopez 2011-11-29 22:47:01 UTC
Review of attachment 202400 [details] [review]:

Seems you forgot to merge your new change in the old patch?
Comment 7 Tom Tryfonidis 2011-11-30 19:33:44 UTC
Created attachment 202478 [details] [review]
merged the patches

Oh my bad..
Here's the new patch.
Comment 8 Xan Lopez 2011-11-30 19:52:00 UTC
Review of attachment 202478 [details] [review]:

::: data/pages/about.css
@@ +71,1 @@
   text-align: right;

This still touches a bit about:epiphany :)

If you don't have commit rights I'll commit this without these bits, otherwise please change them before committing.
Comment 9 Tom Tryfonidis 2011-11-30 20:03:51 UTC
No i don't have commit rights,so it's up to you now.
Comment 10 Xan Lopez 2011-12-01 08:32:32 UTC
I've pushed this to master, commit 9a6c740d24b1d4a7deb846d0a1548c5419e0080e

Thanks for the patch!