After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663815 - app: Fix crash on search
app: Fix crash on search
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 666934 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-11-10 22:45 UTC by Ray Strode [halfline]
Modified: 2012-02-21 19:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
app: Fix crash on search (1.81 KB, patch)
2011-11-10 22:45 UTC, Ray Strode [halfline]
committed Details | Review
app: Fix crash on search (1.81 KB, patch)
2011-11-10 22:46 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2011-11-10 22:45:17 UTC
Not all desktop files tracked by the shell have
Exec lines.  This could be because they're actually
run by another process, for instance, and the desktop
file is merely there to provide metadata.  For example,
nautilus-pastebin provides a desktop file without an
Exec line.

The shell currently crashes if one of these partial
desktop files is installed and the user attempts to
search from the overview.

commit 37726a4cb69ab54298a3c95ccf469e1ab87ed4b1 fixed
a similar crasher.

This commit fixes the next one lower in the code.
Comment 1 Ray Strode [halfline] 2011-11-10 22:45:18 UTC
Created attachment 201196 [details] [review]
app: Fix crash on search
Comment 2 Ray Strode [halfline] 2011-11-10 22:46:45 UTC
The following fix has been pushed:
46cea67 app: Fix crash on search
Comment 3 Ray Strode [halfline] 2011-11-10 22:46:49 UTC
Created attachment 201197 [details] [review]
app: Fix crash on search

Not all desktop files tracked by the shell have
Exec lines.  This could be because they're actually
run by another process, for instance, and the desktop
file is merely there to provide metadata.  For example,
nautilus-pastebin provides a desktop file without an
Exec line.

The shell currently crashes if one of these partial
desktop files is installed and the user attempts to
search from the overview.

commit 37726a4cb69ab54298a3c95ccf469e1ab87ed4b1 fixed
a similar crasher.

This commit fixes the next one lower in the code.
Comment 4 Florian Müllner 2011-11-10 22:55:32 UTC
This issue was already addressed in bug 662409 - given that we get all entries through gmenu, how did you manage to get the crash?
Comment 5 Vitaly Bordug 2012-01-11 09:37:52 UTC
*** Bug 666934 has been marked as a duplicate of this bug. ***
Comment 6 Ray Strode [halfline] 2012-01-16 23:18:07 UTC
re comment 4 (which I just happened to notice, woops), I have no idea, I only vaguely remember this bug.  I think someone brought their laptop to me with a crasher and asked for help so I used gdb to figure it out. It could be that machine had an older gnome-menus.

I talked to walters about the patch at the time and he said it seemed right.  If we don't need the the null exec checks, we should drop both of them.  I guess it doesn't really matter in practice though.
Comment 7 Jony Kalavera 2012-02-21 17:55:39 UTC
i used the commands sugested here: 

https://bugzilla.redhat.com/show_bug.cgi?id=743223 

to find the offender files. 

/usr/share/applications/firefox.desktop
/usr/share/applications/gnome-screenshot.desktop
/usr/share/applications/gnome-terminal.desktop
/usr/share/applications/google-chrome.desktop
/usr/share/applications/libreoffice-calc.desktop
/usr/share/applications/libreoffice-draw.desktop
/usr/share/applications/libreoffice-impress.desktop
/usr/share/applications/libreoffice-math.desktop
/usr/share/applications/libreoffice-writer.desktop
/usr/share/applications/terminator.desktop

turns out all of this do have both Name and Exec fields. They eaven have multiple entries of name for each language and a special entry of exec for new windows. 

http://pastebin.com/Nee5JGM9

the solution above sugests to uninstall this programs. this is not acceptable
i can't live without terminator or firefox. can anyone suggest a diferent work around?
Comment 8 Florian Müllner 2012-02-21 18:04:07 UTC
(In reply to comment #7)
> turns out all of this do have both Name and Exec fields. They eaven have
> multiple entries of name for each language and a special entry of exec for new
> windows.

Then you are experiencing a different bug.
Comment 9 Jony Kalavera 2012-02-21 18:08:04 UTC
can you tell me how can i find some meaningful error information to search for existing bug reports please.
Comment 10 Jony Kalavera 2012-02-21 19:36:41 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > turns out all of this do have both Name and Exec fields. They eaven have
> > multiple entries of name for each language and a special entry of exec for new
> > windows.
> 
> Then you are experiencing a different bug.

can you tell me how can i find some meaningful error information to search for
existing bug reports please.

(forgot to put it as a reply)
Comment 11 Florian Müllner 2012-02-21 19:50:13 UTC
Unfortunately, most crash reports use very general subject (search for instance for "product:gnome-shell crash"); if you know how to get a backtrace[0], you can compare with existing attachments if it's a match. When in doubt, you can just file a new report - if it happens to be a duplicate, it'll be closed, no big deal :)

[0] http://live.gnome.org/GnomeShell/Debugging