After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662687 - "tray" button issues
"tray" button issues
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: keyboard
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 659744 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-25 16:24 UTC by William Jon McCann
Modified: 2013-02-14 16:35 UTC
See Also:
GNOME target: 3.8
GNOME version: ---


Attachments
messageTray: Always hide while the OSK is up (4.97 KB, patch)
2013-02-12 21:05 UTC, Florian Müllner
committed Details | Review
keyboard: Remove 'tray' button (2.34 KB, patch)
2013-02-12 21:05 UTC, Florian Müllner
committed Details | Review
layout: Remove obsolete message tray <=> OSK interaction code (2.84 KB, patch)
2013-02-12 21:05 UTC, Florian Müllner
committed Details | Review

Description William Jon McCann 2011-10-25 16:24:46 UTC
The tray button in the on screen keyboard has a few issues.

 * It looks a bit funny in lowercase to me
 * It doesn't hide the tray when a bubble is up
 * It doesn't show the state
Comment 1 Allan Day 2012-07-14 12:58:17 UTC
See bug 659744.
Comment 2 Alexandre Franke 2012-09-28 07:09:21 UTC
 * It doesn't really work with translations (e.g. in French tray is « tiroir de messagerie » which is waaaaaay too long to be displayed correctly)
Comment 3 Matthias Clasen 2012-10-11 11:57:55 UTC
*** Bug 659744 has been marked as a duplicate of this bug. ***
Comment 4 Matthias Clasen 2012-10-11 12:23:29 UTC
Another issue: With multiple monitors, we need the osk to always appear on the monitor where the keyboard focus is. That may not be the monitor with the message tray. If the osk is on a non-primary monitor, the button does not make sense.
Comment 5 Matthias Clasen 2013-01-22 14:05:16 UTC
the 'pop up on the right monitor' issue mentioned in comment #4 is fixed.
Comment 6 Matthias Clasen 2013-02-10 18:55:01 UTC
would be nice to make some progress here - this seems like an easy fix.

Here's a few proposals for what to use instead of the text:

✉ U+2709 ENVELOPE
☀ U+2600 BLACK SUN WITH RAYS
✆ U+2706 TELEPHONE LOCATION SIGN
❦ U+2766 FLORAL HEART
Comment 7 William Jon McCann 2013-02-11 20:14:19 UTC
I wonder whether we really need to show the tray in this entirely different manner or whether we need to use a keyboard in the tray at all...
Comment 8 Florian Müllner 2013-02-11 20:48:34 UTC
(In reply to comment #7)
> I wonder whether we really [...] to use a keyboard in the tray at all...

If we are OK with having chat notifications not work on touch I guess not.
Comment 9 William Jon McCann 2013-02-11 20:57:51 UTC
Yeah I'd really like us to have the Chat app for that case. I don't think typing in the message tray is going to be that useful on a touch device...
Comment 10 Matthias Clasen 2013-02-12 15:11:56 UTC
so, what is the proposal, then ?
just remove the tray button ?
Comment 11 William Jon McCann 2013-02-12 15:36:04 UTC
I think that would have to be done in concert with an updated keyboard design that doesn't overlay. Perhaps we can use the same mechanism in the shell to display the OSK. Think of it as putting the keyboard in the tray... Need to mock this up probably.
Comment 12 Florian Müllner 2013-02-12 18:57:13 UTC
Not 3.8 material then? Removing the button is perfectly doable til next week, implementing a completely new (and non-existent?) design for the OSK is not ...
Comment 13 Florian Müllner 2013-02-12 21:05:30 UTC
Created attachment 235817 [details] [review]
messageTray: Always hide while the OSK is up

The message tray currently operates in three modes: in the overview,
normal, and while the on-screen keyboard is up. The last case is
particularly odd, and exclusively used for chat-notifications. As
users can still use the Chat application directly on touch-only
devices, the additional mode isn't really justified, so remove it.
Comment 14 Florian Müllner 2013-02-12 21:05:36 UTC
Created attachment 235818 [details] [review]
keyboard: Remove 'tray' button

Now that message tray and keyboard are never shown together, the
odd 'tray' button is pointless, kill it.
Comment 15 Florian Müllner 2013-02-12 21:05:41 UTC
Created attachment 235819 [details] [review]
layout: Remove obsolete message tray <=> OSK interaction code

Message tray and on-screen keyboard are now exclusive, so remove
all code that shuffles boxes around to make it possible to show
both at the same time.
Comment 16 Florian Müllner 2013-02-12 21:08:02 UTC
There was some discussion on #gnome-design regarding a short-term approach, which basically consists in removing the tray button altogether.
Comment 17 Jasper St. Pierre (not reading bugmail) 2013-02-12 21:12:30 UTC
Review of attachment 235817 [details] [review]:

::: js/ui/messageTray.js
@@ +2244,3 @@
                                      this._desktopCloneState == State.SHOWN);
         let desktopCloneShouldBeVisible = (trayShouldBeVisible &&
+                                           !this._overviewVisible);

This can be on one line now.

@@ +2249,3 @@
             this._showDesktopClone();
         } else if (desktopCloneIsVisible && !desktopCloneShouldBeVisible) {
+            this._hideDesktopClone (false);

We always pass "false" here. Remove the parameter altogether (and fix the style nit)
Comment 18 Jasper St. Pierre (not reading bugmail) 2013-02-12 21:13:27 UTC
Review of attachment 235818 [details] [review]:

OK.
Comment 19 Jasper St. Pierre (not reading bugmail) 2013-02-12 21:13:42 UTC
Review of attachment 235819 [details] [review]:

OK.
Comment 20 Florian Müllner 2013-02-14 16:35:26 UTC
Attachment 235817 [details] pushed as a534a6b - messageTray: Always hide while the OSK is up
Attachment 235818 [details] pushed as a21e76c - keyboard: Remove 'tray' button
Attachment 235819 [details] pushed as 2d9cf19 - layout: Remove obsolete message tray <=> OSK interaction code

(In reply to comment #17)
> This can be on one line now.

It could, but I still try to not exceed the splinter/80-chars-terminal limit by too much (even though messageTray.js is pretty hopeless with regard to excessive line length ...)


> @@ +2249,3 @@
> We always pass "false" here. Remove the parameter altogether

Yeah, fixed.