After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662093 - should warns about no numlock when entering password
should warns about no numlock when entering password
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: dialog
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
: 673084 673124 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-18 13:39 UTC by Pedro Villavicencio
Modified: 2012-03-30 22:25 UTC
See Also:
GNOME target: ---
GNOME version: 3.1/3.2

Attachments
lock: drop numlock warning (1.90 KB, patch)
2012-03-30 22:23 UTC, Ray Strode [halfline] 		committed Details | Review

Description Pedro Villavicencio 2011-10-18 13:39:16 UTC 
this report has been filed here:

https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/835649

"I am entering my password and it warns me that I have numlock on. On a desktop or laptop with full keyboard it would be more appropriate to warn when numlock isn't on."

https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/835649/+attachment/2323761/+files/numlock.png
Comment 1 Steve Fosdick 2011-10-19 21:29:06 UTC 
I had a quick look at the code here.  In gnome-screensaver this warning is hard-coded rather than depending on a config key.  If that issue were solved there is a further issue that a GTK Entry widget in password mode displays a warning icon with tooltip text.  This can be controlled by setting the caps-lock-warning property to false but this would also disable the cap lock warning which _is_ useful.
Comment 2 Sebastian 2011-10-25 16:21:52 UTC 
I think we can confirm this bug. On a laptop this need to warn if num lock while on a desktop is needs to warn when num lock is off (so its opposite to each other). While caps is same for laptop and desktop, needs to warn when on.

These config options should not be hard coded and it should also be possible to configure this independent from each other.
Comment 3 Rimas Kudelis 2011-11-08 18:22:17 UTC 
I think this shouldn't really be gnome-screensaver specific. Whether a GTK Entry widget in password mode should warn about numlock on or off should be configurable. It could be just a gsetting perhaps, but it should exist.
Comment 4 Rimas Kudelis 2011-11-08 18:27:09 UTC 
(In reply to comment #3)
> I think this shouldn't really be gnome-screensaver specific. Whether a GTK
> Entry widget in password mode should warn about numlock on or off should be
> configurable. It could be just a gsetting perhaps, but it should exist.

Which is apparently bug 658875...
Comment 5 Marc Deslauriers 2012-02-06 13:14:23 UTC 
I don't think this is an easy problem to solve. The status of the NumLock key is hardware specific, and a lot of hardware lies about it's status.

See my comments in bug 658875.

The best thing to do, IMO, is to drop the numlock warning from Gtk+, and from gnome-screensaver.
Comment 6 Ray Strode [halfline] 2012-03-30 22:23:16 UTC 
Created attachment 211001 [details] [review]
lock: drop numlock warning

It's causing all sorts of complaints.
Comment 7 Ray Strode [halfline] 2012-03-30 22:23:44 UTC 
Attachment 211001 [details] pushed as 910a31a - lock: drop numlock warning
Comment 8 Ray Strode [halfline] 2012-03-30 22:24:24 UTC 
*** Bug 673084 has been marked as a duplicate of this bug. ***
Comment 9 Ray Strode [halfline] 2012-03-30 22:25:37 UTC 
*** Bug 673124 has been marked as a duplicate of this bug. ***