After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661902 - Banshee manual: Empty section "common problems"
Banshee manual: Empty section "common problems"
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: docs
git master
Other Linux
: Normal normal
: ---
Assigned To: Maintainers of Gnome user documentation
Maintainers of Gnome user documentation
Depends on:
Blocks:
 
 
Reported: 2011-10-16 12:52 UTC by Chow Loong Jin
Modified: 2012-11-25 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Removed empty section "Common Problems" (1.50 KB, patch)
2012-11-23 11:41 UTC, Sindhu S 		rejected Details | Review
Removed empty section "Common Problems" (635 bytes, patch)
2012-11-24 18:28 UTC, Sindhu S 		needs-work Details | Review
Removed empty section "Common Problems", Added to TODO file. (1.43 KB, patch)
2012-11-25 16:06 UTC, Sindhu S 		committed Details | Review

Description Chow Loong Jin 2011-10-16 12:52:22 UTC 
Originally reported at:
  https://bugs.launchpad.net/bugs/875586

Banshee -> Help-> Contents.  Scroll down. Notice that "Common Problems" is empty.

Seems to be an upstream bug.  Because the same is true of the online manual.  http://library.gnome.org/users/banshee/1.8/index.html.en

I believe this could be caused by the absence of help/C/problems.page.
Comment 1 Sindhu S 2012-11-23 11:41:57 UTC 
Created attachment 229718 [details] [review]
Removed empty section "Common Problems"
Comment 2 Kat 2012-11-23 21:19:32 UTC 
Review of attachment 229718 [details] [review]:

I think you accidentally attached the wrong patch, this one adds shuffle mode information! :)

::: help/C/play.page
@@ +56,3 @@
   </p>
+
+  <p>Banshee can play your music in a random order, which is known as "Shuffle". Select <guiseq><gui>Playback</gui><gui>Shuffle</gui></guiseq> to choose your shuffle mode. </p>

You need to make sure that the line is
Comment 3 Sindhu S 2012-11-24 18:25:51 UTC 
Whoops!! Sincere apologies.
Comment 4 Sindhu S 2012-11-24 18:28:33 UTC 
Created attachment 229780 [details] [review]
Removed empty section "Common Problems"
Comment 5 Kat 2012-11-24 18:53:46 UTC 
Review of attachment 229780 [details] [review]:

Patch itself is fine. There is a TODO file in the help/C/ directory, add the task to it and re-submit the patch, including the updated TODO file.
Comment 6 Sindhu S 2012-11-25 16:06:29 UTC 
Created attachment 229821 [details] [review]
Removed empty section "Common Problems", Added to TODO file.
Comment 7 Kat 2012-11-25 16:43:00 UTC 
Review of attachment 229821 [details] [review]:

Pushed to master in commit 0133c4aa8866640e1c3e4eae4f0eb66dc0fa5952

The only thing I changed was the subject to include the bug number within the 50 character limit, please do this for all future patches that fix bugs on Bugzilla as that will automatically link to the right bug from git.gnome.org.

Thank you for the patch!