After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658444 - g-o-a credential window seems to doesn't inherit from proxy settings
g-o-a credential window seems to doesn't inherit from proxy settings
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.1.x
Other All
: Normal critical
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-09-07 10:17 UTC by Baptiste Mille-Mathias
Modified: 2011-09-22 19:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (59.10 KB, image/png)
2011-09-07 11:08 UTC, Baptiste Mille-Mathias
  Details
Let authentication webkit window inherit from GNOME proxy settings (bug #658444) (3.15 KB, patch)
2011-09-08 18:48 UTC, Baptiste Mille-Mathias
none Details | Review
Let authentication webkit window inherit from GNOME proxy settings (bug #658444) (3.84 KB, patch)
2011-09-09 13:23 UTC, Frederic Peters
none Details | Review
Let authentication webkit window inherit from GNOME proxy settings (bug #658444) (3.85 KB, patch)
2011-09-09 13:37 UTC, Frederic Peters
reviewed Details | Review

Description Baptiste Mille-Mathias 2011-09-07 10:17:34 UTC
Hi,

I'm working in a closed secure network where all outbound communication should use a proxy (even DNS request are denied, I can't resolve www.google.com from my machine as this is proxy's work), so I set according the required parameters and it works fine in applications like epiphany (works fine at 1st start without modifying a setting).

in g-o-a, I press the + button, and choose google, the authentication window returns me an HTTP error message:
+----------------------------------------------------------------------------+
| Unable to load page                                                        |
|                                                                            |
| Problem occurred while loading the URL https://www.google.com/accounts /OAuthAuthorizeToken?oauth_token=dqdqdqdqdqsdqcnwxd
|                                                                            |
| Cannot resolve hostname (www.google.com)                                   |
+----------------------------------------------------------------------------+
Comment 1 Baptiste Mille-Mathias 2011-09-07 11:08:56 UTC
Created attachment 195852 [details]
screenshot
Comment 2 Baptiste Mille-Mathias 2011-09-08 18:48:44 UTC
Created attachment 196030 [details] [review]
Let authentication webkit window inherit from GNOME proxy settings (bug #658444)

Add a dependency on libsoup-gnome
Comment 3 Baptiste Mille-Mathias 2011-09-08 18:50:22 UTC
Comment on attachment 196030 [details] [review]
Let authentication webkit window inherit from GNOME proxy settings (bug #658444)

I didn't compiled the patch nor tested it, just assume it would work from the doc I read.
Comment 4 Frederic Peters 2011-09-09 13:23:15 UTC
Created attachment 196112 [details] [review]
Let authentication webkit window inherit from GNOME proxy settings (bug #658444)

Add a dependency on libsoup-gnome
Comment 5 Frederic Peters 2011-09-09 13:25:04 UTC
Thanks; I fixed some little build issues and tested it, not in the exact same situation but with a proxy nevertheless.
Comment 6 Frederic Peters 2011-09-09 13:37:22 UTC
Created attachment 196114 [details] [review]
Let authentication webkit window inherit from GNOME proxy settings (bug #658444)

Add a dependency on libsoup-gnome
Comment 7 David Zeuthen (not reading bugmail) 2011-09-12 15:33:05 UTC
(In reply to comment #3)
> (From update of attachment 196030 [details] [review])
> I didn't compiled the patch nor tested it, just assume it would work from the
> doc I read.

You went through all the effort of creating a patch but didn't test it? You do realize that it's difficult to test unless you are in the unfortunate situation (e.g. "closed secure network where all outbound communication should
use a proxy") that you described in comment 0, right?

TBH, I'd expect WebKit-gtk to automagically pick up the correct proxy settings. But I guess we can add this patch provided that you test it.

Thanks for your effort.
Comment 8 David Zeuthen (not reading bugmail) 2011-09-12 15:34:34 UTC
Review of attachment 196114 [details] [review]:

Patch looks OK but would be good to test it in the situation described by comment 0. Thanks.
Comment 9 Matthias Clasen 2011-09-17 18:38:19 UTC
Probably not a priority for 3.2, anyway. 
If testing happens, it can still land.
Comment 10 Baptiste Mille-Mathias 2011-09-19 06:59:43 UTC
If you can add it to the fedora package, I can test it.
Comment 11 Baptiste Mille-Mathias 2011-09-21 11:23:26 UTC
Matthias, David, in the comment Frededic said he tested the patch. Do you need further tests or is it enough to commit it ?

Regards.
Comment 12 David Zeuthen (not reading bugmail) 2011-09-21 11:24:47 UTC
If it's tested, then sure, please commit it and close the bug. Thanks!
Comment 13 Baptiste Mille-Mathias 2011-09-22 19:56:52 UTC
Problem Fixed,

Thanks to Frederic (sorry you're not credited in the commit).

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.