GNOME Bugzilla – Bug 658444
g-o-a credential window seems to doesn't inherit from proxy settings
Last modified: 2011-09-22 19:56:52 UTC
Hi, I'm working in a closed secure network where all outbound communication should use a proxy (even DNS request are denied, I can't resolve www.google.com from my machine as this is proxy's work), so I set according the required parameters and it works fine in applications like epiphany (works fine at 1st start without modifying a setting). in g-o-a, I press the + button, and choose google, the authentication window returns me an HTTP error message: +----------------------------------------------------------------------------+ | Unable to load page | | | | Problem occurred while loading the URL https://www.google.com/accounts /OAuthAuthorizeToken?oauth_token=dqdqdqdqdqsdqcnwxd | | | Cannot resolve hostname (www.google.com) | +----------------------------------------------------------------------------+
Created attachment 195852 [details] screenshot
Created attachment 196030 [details] [review] Let authentication webkit window inherit from GNOME proxy settings (bug #658444) Add a dependency on libsoup-gnome
Comment on attachment 196030 [details] [review] Let authentication webkit window inherit from GNOME proxy settings (bug #658444) I didn't compiled the patch nor tested it, just assume it would work from the doc I read.
Created attachment 196112 [details] [review] Let authentication webkit window inherit from GNOME proxy settings (bug #658444) Add a dependency on libsoup-gnome
Thanks; I fixed some little build issues and tested it, not in the exact same situation but with a proxy nevertheless.
Created attachment 196114 [details] [review] Let authentication webkit window inherit from GNOME proxy settings (bug #658444) Add a dependency on libsoup-gnome
(In reply to comment #3) > (From update of attachment 196030 [details] [review]) > I didn't compiled the patch nor tested it, just assume it would work from the > doc I read. You went through all the effort of creating a patch but didn't test it? You do realize that it's difficult to test unless you are in the unfortunate situation (e.g. "closed secure network where all outbound communication should use a proxy") that you described in comment 0, right? TBH, I'd expect WebKit-gtk to automagically pick up the correct proxy settings. But I guess we can add this patch provided that you test it. Thanks for your effort.
Review of attachment 196114 [details] [review]: Patch looks OK but would be good to test it in the situation described by comment 0. Thanks.
Probably not a priority for 3.2, anyway. If testing happens, it can still land.
If you can add it to the fedora package, I can test it.
Matthias, David, in the comment Frededic said he tested the patch. Do you need further tests or is it enough to commit it ? Regards.
If it's tested, then sure, please commit it and close the bug. Thanks!
Problem Fixed, Thanks to Frederic (sorry you're not credited in the commit). This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.