After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657565 - Banshee has some unchangeable accels in the menu
Banshee has some unchangeable accels in the menu
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
2.0.1
Other Linux
: Normal normal
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-28 16:41 UTC by Chow Loong Jin
Modified: 2011-09-11 17:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix unconfigurable accels (3.89 KB, patch)
2011-08-28 16:42 UTC, Chow Loong Jin
reviewed Details | Review
Updated patch that does not override accelerators of stock items (3.08 KB, patch)
2011-09-11 14:40 UTC, Chow Loong Jin
committed Details | Review

Description Chow Loong Jin 2011-08-28 16:41:44 UTC
From https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/836136:

Some actions in the menu have unconfigurable accels, even after setting
/desktop/gnome/interface/can_change_accels to true. These are caused by
ActionEntry being constructed with null accels as opposed to "" (empty string).
Comment 1 Chow Loong Jin 2011-08-28 16:42:59 UTC
Created attachment 194973 [details] [review]
Patch to fix unconfigurable accels
Comment 2 Bertrand Lorentz 2011-08-29 18:58:33 UTC
Review of attachment 194973 [details] [review]:

From what I can see, the accelerators are editable for actions that don't have a stock_id set (the 2nd parameter to ActionEntry).
So this patch only makes a difference for the actions that have stock_id set, like TrackPropertiesAction. According to the docs, in this case, this overrides any default accelerator defined for that stock action.

So I'm not sure we want those accelerators to be overridable. But I'm a bit fuzzy on that "stock" thing, so I'd be happy to be enlightened...

See also :
http://developer.gnome.org/gtk/stable/GtkActionGroup.html#gtk-action-group-add-action-with-accel
Comment 3 Chow Loong Jin 2011-09-11 14:40:37 UTC
Created attachment 196210 [details] [review]
Updated patch that does not override accelerators of stock items

This patch avoids overriding the accelerators of stock items as mentioned in the previous comment.
Comment 4 Bertrand Lorentz 2011-09-11 17:24:03 UTC
Review of attachment 196210 [details] [review]:

Committed, thanks !
Comment 5 Bertrand Lorentz 2011-09-11 17:24:17 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.