After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656176 - Banshee does not read last value in .is_audio_player when it does not end with '\n'
Banshee does not read last value in .is_audio_player when it does not end wit...
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - USB Mass Storage
git master
Other Linux
: Normal normal
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-08 19:51 UTC by William Witt
Modified: 2011-08-17 20:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
force collection of final value (1.55 KB, patch)
2011-08-11 02:44 UTC, William Witt
committed Details | Review

Description William Witt 2011-08-08 19:51:34 UTC
Test Case:
1.) Plug in and mount mass storage device (I used a thumb drive)
2.) Create .is_audio_player file on device with the following contents:
audio_folders=MUSIC/
output_formats=application/ogg,audio/x-ms-wma,audio/flac,audio/x-wav,audio/mpeg
playlist_format=audio/x-mpegurl
3) Start Banshee
4) See that the device is listed
5) View properties (advanced)
6) Note that playlists are not supported

My understanding is that setting the playlist_format should be sufficient to trigger playlist support.

Noted that in Banshee.Dap.MassStorage/MassStorageDevice.cs (line 129)it merges "playlist_formats" instead of "playlist_format", but changing either the merge or the .is_audio_player file did not solve the problem.
Comment 1 William Witt 2011-08-08 19:56:43 UTC
See Novell bug 599830 for background.

https://bugzilla.novell.com/show_bug.cgi?id=595830
Comment 2 William Witt 2011-08-08 20:13:26 UTC
Setting the argument:
playlist_formats=audio/x-scpls, audio/mpegurl, audio/x-mpegurl

enables playlist support, but only for .pls playlists
Comment 3 William Witt 2011-08-08 20:24:45 UTC
setting:
playlist_formats=audio/mpegurl, audio/x-mpegurl, audio/m3u

allows banshee to save .m3u play lists, but all three must be present.
Comment 4 William Witt 2011-08-08 20:26:35 UTC
Updated title to better capture the issue.
Comment 5 James Ogley 2011-08-09 09:05:24 UTC
Except for me, even with them all listed, it still doesn't work.
Comment 6 William Witt 2011-08-09 11:49:08 UTC
(In reply to comment #5)
> Except for me, even with them all listed, it still doesn't work.

I'd like to ensure that you did notice the change from "playlist_format" to "playlist_formats".  This worked for me both on a thumb drive and my wife's Saza Fuze+.
Comment 7 James Ogley 2011-08-09 12:01:49 UTC
Whoops, sorry - then I now confirm all that William has reported! (Nokia X6 here)
Comment 8 William Witt 2011-08-11 02:02:23 UTC
Discovered that banshee drops the last config property if there is no carriage return at the end of the file.  The following works if there if there is a blank line at the end:
<file>
audio_folders=MUSIC/
output_formats=application/ogg,audio/x-ms-wma,audio/flac,audio/x-wav,audio/mpeg
playlist_formats=audio/x-mpegurl

</file>
Comment 9 William Witt 2011-08-11 02:44:09 UTC
Created attachment 193610 [details] [review]
force collection of final value
Comment 10 Bertrand Lorentz 2011-08-17 20:30:57 UTC
Comment on attachment 193610 [details] [review]
force collection of final value 

Thanks for the patch, committed with minor changes : string instead of String, and rewording of the commit message
Comment 11 Bertrand Lorentz 2011-08-17 20:31:07 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.