After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655415 - Support depth color when Vinagre (VNC) is called for sharing desktop
Support depth color when Vinagre (VNC) is called for sharing desktop
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: VNC
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-27 11:51 UTC by Ignacio
Modified: 2011-08-02 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Vinagre Color Depth Menu (43.08 KB, image/png)
2011-08-01 14:15 UTC, Ignacio
  Details
Use 8 bits color depth when connecting through a Telepathy tube (905 bytes, patch)
2011-08-02 08:09 UTC, Guillaume Desmottes
needs-work Details | Review
Use 8 bits color depth when connecting through a Telepathy tube (1.35 KB, patch)
2011-08-02 15:26 UTC, Guillaume Desmottes
committed Details | Review

Description Ignacio 2011-07-27 11:51:58 UTC
Right now Empathy 2.32.1 and Jabber accounts integration with Gnome's Vinagre is great. I can offer simple Ubuntu support for friends and family in just two clicks. I believe this is a powerful feature.

But there's a problem which I think should be easy to resolve: changing color depth. This VNC feature makes VNC much faster, and it's critical when working with small bandwidth.

Vinagre supports different color depths, but it seems that the way it is called from Empathy opens it with "best quality" settings, being impossible to change them. I don't know how this works, but maybe it's just a matter of a command line option when vinagre is called.
Comment 1 Guillaume Desmottes 2011-08-01 12:59:39 UTC
How do you tweak the color depth in Vinagre? I didn't find any option.
Comment 2 Ignacio 2011-08-01 14:15:36 UTC
Created attachment 192983 [details]
Vinagre Color Depth Menu
Comment 3 Ignacio 2011-08-01 14:18:21 UTC
Hi Guillaume,

In Vinagre 2.30.2, when you clic on "Connect", a menu appears in which you can select the color depth you want. I just attached a screenshot.
Comment 4 Guillaume Desmottes 2011-08-01 14:30:02 UTC
Oh right thanks. This should be done directly in Vinagre actually. Would 16 bits be a good default?
Comment 5 Ignacio 2011-08-01 14:36:59 UTC
I would prefer 8 bit, which still works great and saves a lot of bandwidth.
Comment 6 Guillaume Desmottes 2011-08-02 08:09:47 UTC
Created attachment 193037 [details] [review]
Use 8 bits color depth when connecting through a Telepathy tube
Comment 7 David King 2011-08-02 08:36:38 UTC
Review of attachment 193037 [details] [review]:

I guess that this also affect tubes via link-local XMPP? I think that as those are local connections, they should not be set to a low colour depth.
Comment 8 Guillaume Desmottes 2011-08-02 15:26:02 UTC
Created attachment 193085 [details] [review]
Use 8 bits color depth when connecting through a Telepathy tube
Comment 9 David King 2011-08-02 15:53:08 UTC
Review of attachment 193085 [details] [review]:

This is perfect, thanks! I added some explanation in the commit message and pushed this to master as commit b2ab39a6be0894dee93721a18fa028166da437f2.
Comment 10 Ignacio 2011-08-02 16:09:26 UTC
Thank you very much!