After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655375 - Allow using drag and drop for adding wallpapers
Allow using drag and drop for adding wallpapers
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
3.0.x
Other Linux
: Normal enhancement
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 657016 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-07-26 23:14 UTC by Jean-François Fortin Tam
Modified: 2011-10-06 08:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch which adds support for drag and drop for adding wallpaper (1.93 KB, patch)
2011-10-03 19:58 UTC, mh512
committed Details | Review

Description Jean-François Fortin Tam 2011-07-26 23:14:55 UTC
Currently it is possible to add wallpapers using the tiny "+" button. I would like being able to simply drag any image file onto the gnome-control-center Background panel.

If you want to limit the drop target areas, it could be only the iconview on the left and the "computer screen" preview, but I think it would be better to make the whole panel receptive to DnD.

Thanks!
Comment 1 Bastien Nocera 2011-08-21 17:12:24 UTC
*** Bug 657016 has been marked as a duplicate of this bug. ***
Comment 2 mh512 2011-09-09 19:51:00 UTC
Is it ok if I submit a patch to solve this?

Thanks!
Comment 3 Hylke Bons 2011-09-09 19:55:49 UTC
(In reply to comment #2)
> Is it ok if I submit a patch to solve this?
> 
> Thanks!

Ofcourse, please do!
Comment 4 mh512 2011-10-03 19:58:30 UTC
Created attachment 198145 [details] [review]
Patch which adds support for drag and drop for adding wallpaper

Attached is a patch.
I have limited the target area to "scrolledwindow1". 
(This behavior is similar to gnome 2.8.)

Thanks!
Comment 5 Bastien Nocera 2011-10-06 08:49:17 UTC
Added a call to gtk_drag_finish() and added a few spaces before brackets (coding style).

Thanks for the patch!