GNOME Bugzilla – Bug 649391
[jifmux] bump rank from none
Last modified: 2011-05-17 01:03:46 UTC
What is missing to give jifmux a higher rank? It currently has GST_RANK_NONE. I remember that it has the same caps on src and sink pads, is that still a problem these days? The use case is to make it be plugged by encodebin.
I looked at both plugins for bug #626531 and imho the pass the plugin moving check list. I think it would make sense to move them both. Imho playbin2 has now logic to avoid replugging elements, dunno if encodebin is smart in that sense. But then I don't think its going to happen anyway due to the nature how the profiles work.
In decodebin2 replugging is now prevented but we're talking about a "muxer" here, that is never autoplugged by decodebin2 anyway. To my knowledge encodebin does not handle this case yet but it keeps track of all elements anyway and adding support to this should be easy. OTOH encodebin does not implement support for "formatters" like this at all right now. Which leads me to my next comment, jifmux is not a "muxer", it's more a formatter like xingmux or vorbistag. It does not mux anything
Yes, but other than that I can see no reason to not bump its rank at least to secondary. It has been in use for quite some time and there are no open bugs about it currently.
commit 993a98c2382c0a258848919a4fc38b8894c6d1b0 Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk> Date: Fri May 13 15:16:14 2011 -0300 jifmux: Bump rank to secondary jifmux is being used for quite some time and has no open bugs currently, so we can give it a secondary rank at least. Fixes #649391 commit ad68fa583152c3e7da468bb111ead1ef2d86ec74 Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk> Date: Fri May 13 15:15:53 2011 -0300 jifmux: Change class to formatter jifmux is a formatter and not a muxer Fixes #649391